Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@crunch.apache.org
Date: Mon, 14 Apr 2014 14:38:14 +0000 (UTC)
From: "Josh Wills (JIRA)" <jira@apache.org>
To: crunch-dev@incubator.apache.org
Message-ID: <JIRA.12707579.1397081825927.110090.1397486294986@arcas>
In-Reply-To: <JIRA.12707579.1397081825927@arcas>
References: <JIRA.12707579.1397081825927@arcas>
Subject: [jira] [Commented] (CRUNCH-374) Pipeline.done returns READY when
 there is nothing to run
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CRUNCH-374?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1396=
8392#comment-13968392 ]=20

Josh Wills commented on CRUNCH-374:
-----------------------------------

I'm okay with returning SUCEEDED in this case, FWIW.

> Pipeline.done returns READY when there is nothing to run
> --------------------------------------------------------
>
>                 Key: CRUNCH-374
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-374
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Nathan Barry
>            Priority: Minor
>
> It is odd that Pipeline.done() returns a PipelineResult with a status of =
=E2=80=9CREADY=E2=80=9D when there is nothing staged in the pipeline when d=
one is called.  It makes sense to not return =E2=80=9CSUCCEEDED=E2=80=9D as=
 that implies that something happened successfully, but =E2=80=9CREADY=E2=
=80=9D isn=E2=80=99t a terminal state but it=E2=80=99s an initial state so =
checking for a status of READY after calling done is counterintuitive.=20
> Perhaps a new status of =E2=80=9CDONE=E2=80=9D should be returned in this=
 case


--
This message was sent by Atlassian JIRA
(v6.2#6252)