crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Barry (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-374) Pipeline.done returns READY when there is nothing to run
Date Mon, 14 Apr 2014 13:46:28 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968366#comment-13968366
] 

Nathan Barry commented on CRUNCH-374:
-------------------------------------

I do not see running an empty pipeline as being an error state, to me it's a successful action.
 The point you mention about PipelineResult#succeeded returning false is the flow that caused
us issue, we have had to add logic to check for this state when we gather up stats at the
end of our jobs.

> Pipeline.done returns READY when there is nothing to run
> --------------------------------------------------------
>
>                 Key: CRUNCH-374
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-374
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Nathan Barry
>            Priority: Minor
>
> It is odd that Pipeline.done() returns a PipelineResult with a status of “READY”
when there is nothing staged in the pipeline when done is called.  It makes sense to not return
“SUCCEEDED” as that implies that something happened successfully, but “READY” isn’t
a terminal state but it’s an initial state so checking for a status of READY after calling
done is counterintuitive. 
> Perhaps a new status of “DONE” should be returned in this case



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message