crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <>
Subject [jira] [Commented] (CRUNCH-374) Pipeline.done returns READY when there is nothing to run
Date Mon, 14 Apr 2014 06:23:16 GMT


Gabriel Reid commented on CRUNCH-374:

I think that there's a bit of a mismatch between the concept of PipelineResult and a PipelineExcecution.Status
(contained in a PipelineResult). The PipelineExecution.Status is based around the async workflow,
whereas just the existence of a PipelineResult implies a terminal state.

I also see that PipelineResult#succeeded is dependent on the PipelineExecution.Status being
set to SUCCEEDED -- meaning that the PipelineResult from an empty pipeline will return false
for PipelineResult#succeeded.

[] is the case running an empty pipeline something that you see as being
an error state, or equivalent to successfully running a non-empty pipeline?

> Pipeline.done returns READY when there is nothing to run
> --------------------------------------------------------
>                 Key: CRUNCH-374
>                 URL:
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Nathan Barry
>            Priority: Minor
> It is odd that Pipeline.done() returns a PipelineResult with a status of “READY”
when there is nothing staged in the pipeline when done is called.  It makes sense to not return
“SUCCEEDED” as that implies that something happened successfully, but “READY” isn’t
a terminal state but it’s an initial state so checking for a status of READY after calling
done is counterintuitive. 
> Perhaps a new status of “DONE” should be returned in this case

This message was sent by Atlassian JIRA

View raw message