Return-Path: X-Original-To: apmail-crunch-dev-archive@www.apache.org Delivered-To: apmail-crunch-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 460C310E26 for ; Tue, 4 Feb 2014 15:36:14 +0000 (UTC) Received: (qmail 61473 invoked by uid 500); 4 Feb 2014 15:36:11 -0000 Delivered-To: apmail-crunch-dev-archive@crunch.apache.org Received: (qmail 61431 invoked by uid 500); 4 Feb 2014 15:36:10 -0000 Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@crunch.apache.org Delivered-To: mailing list dev@crunch.apache.org Received: (qmail 61412 invoked by uid 500); 4 Feb 2014 15:36:09 -0000 Delivered-To: apmail-incubator-crunch-dev@incubator.apache.org Received: (qmail 61407 invoked by uid 99); 4 Feb 2014 15:36:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 15:36:09 +0000 Date: Tue, 4 Feb 2014 15:36:09 +0000 (UTC) From: "Josh Wills (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CRUNCH-337) Make it easier to use multiple input paths MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890773#comment-13890773 ] Josh Wills commented on CRUNCH-337: ----------------------------------- We do our best. I'll see if any of the other committers have an opinion and if it looks good, I'll commit it later today Pacific Time. > Make it easier to use multiple input paths > ------------------------------------------ > > Key: CRUNCH-337 > URL: https://issues.apache.org/jira/browse/CRUNCH-337 > Project: Crunch > Issue Type: Improvement > Components: Core > Affects Versions: 0.9.0 > Reporter: Matthew Basil > Assignee: Josh Wills > Priority: Minor > Attachments: CRUNCH-337.patch > > > It would be more user-friendly, especially for newbies, to provides methods on {{From}} for creating sources from multiple {{Path}}s. I'm currently attempting to write my first Crunch Pipeline, which needs to read from multiple paths using a custom input format, and I needed to dig into the source for {{From.formattedFile}} to see I need to do something like this > {code} > PTableType tableType = keyType.getFamily().tableOf(keyType, valueType); > return new FileTableSourceImpl(paths, tableType, formatClass); > {code} > I don't particularly mind, but other potential new users might be a bit put off by having to look at the source on the first line of their first pipeline. If it's undesirable to double the number of methods in {{From}} by doing this (which is understandable), it might be nice to add some note on multiple input paths to the section of the users guide on {{Source}}s. > Thanks! -- This message was sent by Atlassian JIRA (v6.1.5#6160)