crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Micah Whitacre (JIRA)" <>
Subject [jira] [Updated] (CRUNCH-357) Allow AvroMode overrides to be less global
Date Wed, 26 Feb 2014 03:43:20 GMT


Micah Whitacre updated CRUNCH-357:

    Attachment: CRUNCH-357.patch

Here's a first pass at the change.  There is still work to be done but wanted to see what
people thought because I believe the change from AvroMode being an enum to a class is non-passive.

Some other outstanding changes:
* setSpecificClassloader being static seems odd and should be made instance level but once
again non-passive
* needs tests
* Add more doc to the class

> Allow AvroMode overrides to be less global
> ------------------------------------------
>                 Key: CRUNCH-357
>                 URL:
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core, IO
>            Reporter: Micah Whitacre
>            Assignee: Micah Whitacre
>         Attachments: CRUNCH-357.patch
> Currently consumers wanting to specify a custom reader must globally override the ReaderFactory
for a specific mode.  This means that if one AvroFileSource changes the factory it could affect
all other sources in the pipeline without anyone knowing it.
> One thought was what if a consumer could get a "local" AvroMode instance, configure it
to their needs and then specify that mode to the AvroFileSource to configure that source without
changing any global state.

This message was sent by Atlassian JIRA

View raw message