crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Durfey (JIRA)" <>
Subject [jira] [Commented] (CRUNCH-356) Use IOUtils.closeQuietly instead of Closeables.closeQuietly
Date Tue, 25 Feb 2014 17:12:24 GMT


Stephen Durfey commented on CRUNCH-356:

A couple months ago I moved away from using IOUtils#closeQuietly. There were some map reduce
jobs failing and the lack of logging on the IOException was hiding the true cause of the job
failures, which were upstream in the pipeline, rather than where the job stop running. Since
then I've moved to a custom solution that ensures the IOExceptions are logged. 

> Use IOUtils.closeQuietly instead of Closeables.closeQuietly
> -----------------------------------------------------------
>                 Key: CRUNCH-356
>                 URL:
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>            Reporter: John Leacox
>            Assignee: Josh Wills
>            Priority: Minor
>             Fix For: 0.10.0, 0.8.3
>         Attachments: patch.diff
> Closeables.closeQuietly was deprecated in Guava 13 and removed in Guava 16. If a consumer
of crunch-core is using Guava 16+ a NoSuchMethodError could occur where Closeables.closeQuietly
is being used.
> The other crunch components are already using IOUtils.closeQuietly, so crunch-core could
pull in common-io and use IOUtils.closeQuietly.

This message was sent by Atlassian JIRA

View raw message