crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chao Shi (JIRA)" <>
Subject [jira] [Created] (CRUNCH-346) Don't deep-copy immutable Writable PTypes
Date Sun, 16 Feb 2014 14:47:19 GMT
Chao Shi created CRUNCH-346:

             Summary: Don't deep-copy immutable Writable PTypes
                 Key: CRUNCH-346
             Project: Crunch
          Issue Type: Improvement
            Reporter: Chao Shi

I found getDetachedValue() appears quite often when jstack on one of my pipeline. A piece
of stacktrace is shown below. In the pipeline, most of types we used are immutable (e.g. java
primitives, strings, protobuf). I think we can avoid deep-copy overhead here.

"main" prio=10 tid=0x00007f0de801d800 nid=0x7ef runnable [0x00007f0dee66c000]
   java.lang.Thread.State: RUNNABLE
	at sun.reflect.GeneratedConstructorAccessor9.newInstance(Unknown Source)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(
	at java.lang.reflect.Constructor.newInstance(
	at java.lang.Class.newInstance0(
	at java.lang.Class.newInstance(
	at org.apache.crunch.types.writable.WritableDeepCopier.deepCopy(
	at org.apache.crunch.types.writable.WritableDeepCopier.deepCopy(
	at org.apache.crunch.types.writable.WritableType.getDetachedValue(

This message was sent by Atlassian JIRA

View raw message