crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Wills (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-331) Change default settings for CombineFileInputFormat
Date Mon, 03 Feb 2014 22:13:06 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889983#comment-13889983
] 

Josh Wills commented on CRUNCH-331:
-----------------------------------

So is the NLineSource. I think the reality is that I made a mistake by having the default
behavior be combine file enabled instead of disabled for subclasses of FileInputFormat, so
the question becomes whether we should bite the bullet and reverse that decision or just work
around it.

> Change default settings for CombineFileInputFormat
> --------------------------------------------------
>
>                 Key: CRUNCH-331
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-331
>             Project: Crunch
>          Issue Type: Bug
>          Components: IO
>    Affects Versions: 0.9.0, 0.8.2
>            Reporter: Josh Wills
>
> Currently, we default to enabling the CombineFileInputFormat settings for any extensions
of FileSourceImpl b/c it tends to improve performance for common file formats like text, sequence
files, and Avro files. However, this default has caused problems for formats like Parquet
and for custom file formats that have complex split logic.
> This JIRA is to track modifying the default combine file settings in at least some contexts,
such as with From.formattedFile for custom input formats.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message