crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Anderson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-322) StoreLastEmitter Should Be Part of crunch-test
Date Thu, 16 Jan 2014 17:02:20 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873607#comment-13873607
] 

Jesse Anderson commented on CRUNCH-322:
---------------------------------------

Not earth shattering, but you might want to add an assertion to check the size of the output
list:
assertEquals("Not the right size", 1, emitter.getOutput().size());

> StoreLastEmitter Should Be Part of crunch-test
> ----------------------------------------------
>
>                 Key: CRUNCH-322
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-322
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.9.0
>            Reporter: Jesse Anderson
>            Assignee: Josh Wills
>         Attachments: CRUNCH-322.patch
>
>
> There aren't many ways of unit testing Crunch that are built in. I'm using crunch-core/src/test/java/org/apache/crunch/fn/StoreLastEmitter.java
to test outputs from DoFN classes.
> This class is not distributed with the crunch-core JAR because it is in the test package.
This class should be moved to the non-test source for crunch-test.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message