Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@crunch.apache.org
Date: Mon, 18 Nov 2013 02:37:21 +0000 (UTC)
From: "Micah Whitacre (JIRA)" <jira@apache.org>
To: crunch-dev@incubator.apache.org
Message-ID: <JIRA.12679144.1384398730682.88559.1384742241385@arcas>
In-Reply-To: <JIRA.12679144.1384398730682@arcas>
References: <JIRA.12679144.1384398730682@arcas>
Subject: [jira] [Updated] (CRUNCH-293) Injection of reader into
 AvroRecordReader
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CRUNCH-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Micah Whitacre updated CRUNCH-293:
----------------------------------

    Attachment: CRUNCH-293_v2.patch

Here's a patch that combines the two factories.  Altered the method names to differentiate the reflect and the specific.  

Still need a bit more verification from some consumers that this handles injection of the reader in all needed cases.

> Injection of reader into AvroRecordReader
> -----------------------------------------
>
>                 Key: CRUNCH-293
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-293
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7.0, 0.8.0
>            Reporter: Micah Whitacre
>            Assignee: Micah Whitacre
>         Attachments: CRUNCH-293.patch, CRUNCH-293_v2.patch
>
>
> With CRUNCH-243, I wanted to support injecting custom readers to handle the cases like passivity between Avro Schema.  The changes made however were not complete as we also need to be able to inject a reader into the AvroRecordReader which constructs its own SpecificDatumReader.
> We could create a SpecificDataFactory which emulates the ReflectDataFactory.  Or simplify to a single DataFactory which will create either Reflect/Specific/Generic.  Thoughts?


--
This message was sent by Atlassian JIRA
(v6.1#6144)