Return-Path: X-Original-To: apmail-crunch-dev-archive@www.apache.org Delivered-To: apmail-crunch-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF5CF10D7D for ; Wed, 20 Nov 2013 20:02:35 +0000 (UTC) Received: (qmail 45882 invoked by uid 500); 20 Nov 2013 20:02:35 -0000 Delivered-To: apmail-crunch-dev-archive@crunch.apache.org Received: (qmail 45846 invoked by uid 500); 20 Nov 2013 20:02:35 -0000 Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@crunch.apache.org Delivered-To: mailing list dev@crunch.apache.org Received: (qmail 45838 invoked by uid 500); 20 Nov 2013 20:02:35 -0000 Delivered-To: apmail-incubator-crunch-dev@incubator.apache.org Received: (qmail 45834 invoked by uid 99); 20 Nov 2013 20:02:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Nov 2013 20:02:35 +0000 Date: Wed, 20 Nov 2013 20:02:35 +0000 (UTC) From: "Ryan Blue (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CRUNCH-293) Injection of reader into AvroRecordReader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828049#comment-13828049 ] Ryan Blue commented on CRUNCH-293: ---------------------------------- Thanks! > Injection of reader into AvroRecordReader > ----------------------------------------- > > Key: CRUNCH-293 > URL: https://issues.apache.org/jira/browse/CRUNCH-293 > Project: Crunch > Issue Type: Improvement > Components: Core > Affects Versions: 0.7.0, 0.8.0 > Reporter: Micah Whitacre > Assignee: Micah Whitacre > Fix For: 0.9.0 > > Attachments: 0001-CRUNCH-293-Add-AvroMode-to-inject-avro-readers.patch, CRUNCH-293.patch, CRUNCH-293_v2.patch > > > With CRUNCH-243, I wanted to support injecting custom readers to handle the cases like passivity between Avro Schema. The changes made however were not complete as we also need to be able to inject a reader into the AvroRecordReader which constructs its own SpecificDatumReader. > We could create a SpecificDataFactory which emulates the ReflectDataFactory. Or simplify to a single DataFactory which will create either Reflect/Specific/Generic. Thoughts? -- This message was sent by Atlassian JIRA (v6.1#6144)