Return-Path: 
 <dev-return-3295-apmail-crunch-dev-archive=crunch.apache.org@crunch.apache.org>
X-Original-To: apmail-crunch-dev-archive@www.apache.org
Delivered-To: apmail-crunch-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8F11410499
	for <apmail-crunch-dev-archive@www.apache.org>;
 Wed, 23 Oct 2013 07:07:59 +0000 (UTC)
Received: (qmail 85776 invoked by uid 500); 23 Oct 2013 07:07:56 -0000
Delivered-To: apmail-crunch-dev-archive@crunch.apache.org
Received: (qmail 83782 invoked by uid 500); 23 Oct 2013 07:07:49 -0000
Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@crunch.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@crunch.apache.org>
List-Post: <mailto:dev@crunch.apache.org>
List-Id: <dev.crunch.apache.org>
Reply-To: dev@crunch.apache.org
Delivered-To: mailing list dev@crunch.apache.org
Received: (qmail 83619 invoked by uid 500); 23 Oct 2013 07:07:44 -0000
Delivered-To: apmail-incubator-crunch-dev@incubator.apache.org
Received: (qmail 83608 invoked by uid 99); 23 Oct 2013 07:07:44 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Oct 2013 07:07:44 +0000
Date: Wed, 23 Oct 2013 07:07:44 +0000 (UTC)
From: "Gabriel Reid (JIRA)" <jira@apache.org>
To: crunch-dev@incubator.apache.org
Message-ID: <JIRA.12673180.1381385883085.108677.1382512064042@arcas>
In-Reply-To: <JIRA.12673180.1381385883085@arcas>
References: <JIRA.12673180.1381385883085@arcas>
Subject: [jira] [Commented] (CRUNCH-278) Improvements to MapsideJoin code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CRUNCH-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802655#comment-13802655 ] 

Gabriel Reid commented on CRUNCH-278:
-------------------------------------

+1

> Improvements to MapsideJoin code
> --------------------------------
>
>                 Key: CRUNCH-278
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-278
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core, MapReduce Patterns
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>         Attachments: CRUNCH-278b.patch, CRUNCH-278c.patch, CRUNCH-278d.patch, CRUNCH-278.patch
>
>
> The fact that we have special-case code in the MapsideJoinStrategy for the in-memory and MR-based Pipeline instances has always bugged me, so I set out to eliminate the distinction between the two impls by creating a new interface, ReadableSourceBundle<T>, that encapsulates the MR and in-memory specific logic for doing mapside joins in order to remove the special-case code in MapsideJoinStrategy and hopefully make other implementations that use our mapside-join patterns much easier to test.



--
This message was sent by Atlassian JIRA
(v6.1#6144)