crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Micah Whitacre (JIRA)" <>
Subject [jira] [Commented] (CRUNCH-279) Allow DoFn.process to throw exceptions
Date Thu, 10 Oct 2013 17:13:43 GMT


Micah Whitacre commented on CRUNCH-279:

I'm kind of curious why you chose to throw a NullPointerException in lieu of simply wrapping
your checked exception inside of something like RuntimeException?  Throwing that will cause
the job to fail as expected.

> Allow DoFn.process to throw exceptions
> --------------------------------------
>                 Key: CRUNCH-279
>                 URL:
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Joseph Adler
>            Assignee: Josh Wills
> Currently, the DoFn process method doesn't throw any exceptions. This forces me to (a)
catch all exceptions internally (which is good), but then (b) do something unnatural (like
a deliberate null pointer exception) to stop processing and cause the job to fail.
> If only we could just throw an exception from DoFn (like, say, an IOException, which
both and Reducer.reduce can throw), we could have a better way to cause a task
to fail on error.
> If other people think this is useful, I'll submit a patch.

This message was sent by Atlassian JIRA

View raw message