crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Wills (JIRA)" <>
Subject [jira] [Updated] (CRUNCH-278) Improvements to MapsideJoin code
Date Tue, 22 Oct 2013 12:44:42 GMT


Josh Wills updated CRUNCH-278:

    Attachment: CRUNCH-278c.patch

All good points-- here's a patch that incorporates the changes as diffs relative to 278b (I'll
rebase them before I submit this, just wanted to make it easier to review.)

I think you're right that we need to keep the default behavior the same for mapside joins--
it would be way too surprising for people upgrading. I handled that by adding a boolean materialize
argument to asReadable() and creating a constructor for MapsideJoin that allows you to set
it to false so folks can experiment with it safely.

> Improvements to MapsideJoin code
> --------------------------------
>                 Key: CRUNCH-278
>                 URL:
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core, MapReduce Patterns
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>         Attachments: CRUNCH-278b.patch, CRUNCH-278c.patch, CRUNCH-278.patch
> The fact that we have special-case code in the MapsideJoinStrategy for the in-memory
and MR-based Pipeline instances has always bugged me, so I set out to eliminate the distinction
between the two impls by creating a new interface, ReadableSourceBundle<T>, that encapsulates
the MR and in-memory specific logic for doing mapside joins in order to remove the special-case
code in MapsideJoinStrategy and hopefully make other implementations that use our mapside-join
patterns much easier to test.

This message was sent by Atlassian JIRA

View raw message