crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Wills (JIRA)" <>
Subject [jira] [Updated] (CRUNCH-278) Improvements to MapsideJoin code
Date Tue, 22 Oct 2013 04:58:42 GMT


Josh Wills updated CRUNCH-278:

    Attachment: CRUNCH-278b.patch

Here's my second cut at this, which reflects our discussion over the past week or so. This
is the full version, which can support processing DoFns in-memory on the cluster for small
data sources in order to save an MR job.

Couple of concerns: the name of the object (ReadableData<T>) isn't the greatest, and
I'd welcome other suggestions. Also, I'm not supporting using a PGroupedTable with this API
right now b/c I think we need to fix how we serialize grouped data in a different JIRA that
will follow this one.

> Improvements to MapsideJoin code
> --------------------------------
>                 Key: CRUNCH-278
>                 URL:
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core, MapReduce Patterns
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>         Attachments: CRUNCH-278b.patch, CRUNCH-278.patch
> The fact that we have special-case code in the MapsideJoinStrategy for the in-memory
and MR-based Pipeline instances has always bugged me, so I set out to eliminate the distinction
between the two impls by creating a new interface, ReadableSourceBundle<T>, that encapsulates
the MR and in-memory specific logic for doing mapside joins in order to remove the special-case
code in MapsideJoinStrategy and hopefully make other implementations that use our mapside-join
patterns much easier to test.

This message was sent by Atlassian JIRA

View raw message