crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Micah Whitacre (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-261) Make HBaseSourceTarget ReadableSource
Date Sat, 07 Sep 2013 22:51:53 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761142#comment-13761142
] 

Micah Whitacre commented on CRUNCH-261:
---------------------------------------

I started on this but didn't get as far as you.  One nit is your patch leaks HBase connections
due to not closing the HTable or ResultScanner you create in the HBaseSourceTarget.  Due to
Java Generics and the value of the ResultScanner it doesn't nicely align with the AutoClosingIterator
but could with some copy/pasting and slight modifications.
                
> Make HBaseSourceTarget ReadableSource
> -------------------------------------
>
>                 Key: CRUNCH-261
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-261
>             Project: Crunch
>          Issue Type: Improvement
>          Components: IO
>            Reporter: Micah Whitacre
>         Attachments: CRUNCH-261.patch
>
>
> HBaseSourceTarget should also implement ReadableSource to allow for mapside joins.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message