crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Wills (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-240) Make DefaultJoinStrategy.join(PTable, PTable, JoinFn) public
Date Fri, 19 Jul 2013 20:56:48 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714065#comment-13714065
] 

Josh Wills commented on CRUNCH-240:
-----------------------------------

Yep, that is the general idea. I hope that this exercise will give us a better feel for what
those abstractions should look like.
                
> Make DefaultJoinStrategy.join(PTable, PTable, JoinFn) public
> ------------------------------------------------------------
>
>                 Key: CRUNCH-240
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-240
>             Project: Crunch
>          Issue Type: Bug
>            Reporter: Josh Wills
>             Fix For: 0.7.0
>
>         Attachments: CRUNCH-240.patch
>
>
> The API refactoring made the default join implementation that allowed clients to specify
custom JoinFn implementations package protected instead of public. This patch makes it public
again so that existing custom JoinFn impls will still work on Crunch 0.7.0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message