crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-216) Transpose arguments in MapsideJoinStrategy.join
Date Mon, 10 Jun 2013 14:48:22 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679554#comment-13679554
] 

Gabriel Reid commented on CRUNCH-216:
-------------------------------------

Based on what I would expect from myself, neither a javadoc update nor a warning log would
make me notice it right away I don't think.  Well, definitely not the log because the logging
is already pretty verbose as it is, so it's hard to make something stand out.

On the other hand, a call that was previously:

   MapsideJoin.join(left, right);

will no longer compile, with the new version being:

    new MapsideJoinStrategy().join(left, right, JoinType.INNER_JOIN);

so the fact that existing code will break and a new parameter is introduced will possibly
force people to look at the javadoc, so maybe just a javadoc update is enough.
                
> Transpose arguments in MapsideJoinStrategy.join
> -----------------------------------------------
>
>                 Key: CRUNCH-216
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-216
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Gabriel Reid
>
> The MapsideJoinStrategy currently specifies that the smaller table in the join (i.e.
the table to be replicated and loaded in memory) should be on the right-hand side of the join.
> This is the opposite of what is done in all other join strategies, making it impossible
to just switch out another join strategy for a MapsideJoinStrategy. The MapsideJoinStrategy
could be brought in line with the other JoinStrategies to expect the smaller of two tables
to be provided as the left-side table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message