Return-Path: X-Original-To: apmail-crunch-dev-archive@www.apache.org Delivered-To: apmail-crunch-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3FD4B101A3 for ; Fri, 5 Apr 2013 19:35:18 +0000 (UTC) Received: (qmail 9909 invoked by uid 500); 5 Apr 2013 19:35:17 -0000 Delivered-To: apmail-crunch-dev-archive@crunch.apache.org Received: (qmail 9867 invoked by uid 500); 5 Apr 2013 19:35:17 -0000 Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@crunch.apache.org Delivered-To: mailing list dev@crunch.apache.org Received: (qmail 9812 invoked by uid 500); 5 Apr 2013 19:35:17 -0000 Delivered-To: apmail-incubator-crunch-dev@incubator.apache.org Received: (qmail 9778 invoked by uid 99); 5 Apr 2013 19:35:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Apr 2013 19:35:17 +0000 Date: Fri, 5 Apr 2013 19:35:17 +0000 (UTC) From: "Gabriel Reid (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (CRUNCH-191) Object reuse bug in o.a.c.lib.Distinct MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Reid resolved CRUNCH-191. --------------------------------- Resolution: Fixed Fix Version/s: 0.6.0 Assignee: Gabriel Reid Pushed to master > Object reuse bug in o.a.c.lib.Distinct > -------------------------------------- > > Key: CRUNCH-191 > URL: https://issues.apache.org/jira/browse/CRUNCH-191 > Project: Crunch > Issue Type: Bug > Reporter: Gabriel Reid > Assignee: Gabriel Reid > Fix For: 0.6.0 > > Attachments: CRUNCH-191.patch > > > A DoFn in the o.a.c.lib.Distinct class holds on to values in a local buffer, but doesn't deep copy the values where necessary. This can lead to unexpected issues with the well-known object-reuse bug, particularly if the same value is used by multiple DoFns. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira