crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-179) Add a properly typed union() method to PCollection and PTable
Date Thu, 07 Mar 2013 07:40:12 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595644#comment-13595644
] 

Gabriel Reid commented on CRUNCH-179:
-------------------------------------

Sounds like a very good plan, those compiler warnings are super annoying.

I'm almost wondering if we should make the varargs version deprecated -- it's just as clear
(or maybe even more so) to write
   
    collectionA.union(collectionB).union(collectionC)

as it is to write

    collectionA.union(collectionB, collectionC)

and then then we can get rid of the compiler warnings (as well as the ease of unioning a collection
of the wrong type) forever.
                
> Add a properly typed union() method to PCollection and PTable
> -------------------------------------------------------------
>
>                 Key: CRUNCH-179
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-179
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>            Priority: Minor
>         Attachments: CRUNCH-179.patch
>
>
> I find myself slightly (albeit persistently) irritated by the warnings that come up in
Eclipse as a function of using varargs for the union method on PCollection and PTable, so
I wrote a union() method that takes a single argument and delegates to the regular union method.
No functional change, just cleans up an irritating warning in my client code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message