Mailing-List: contact crunch-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: crunch-dev@incubator.apache.org
Date: Mon, 14 Jan 2013 16:22:12 +0000 (UTC)
From: "Josh Wills (JIRA)" <jira@apache.org>
To: crunch-dev@incubator.apache.org
Message-ID: <JIRA.12627426.1358169982924.130446.1358180532444@arcas>
In-Reply-To: <JIRA.12627426.1358169982924@arcas>
References: <JIRA.12627426.1358169982924@arcas>
Subject: [jira] [Commented] (CRUNCH-142) Context not being passed to
 FilterFn instances wrapped in boolean AndFn,OrFn,NotFn
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CRUNCH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552838#comment-13552838 ] 

Josh Wills commented on CRUNCH-142:
-----------------------------------

I don't see how it would work in this context-- e.g., what is the right thing for the AndFn's cleanup() method to do that would be consistent w/the AndFn's contract (e.g., only emit a value if it is emitted by all of its children?)
                
> Context not being passed to FilterFn instances wrapped in boolean AndFn,OrFn,NotFn
> ----------------------------------------------------------------------------------
>
>                 Key: CRUNCH-142
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-142
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.4.0
>            Reporter: Dave Beech
>            Assignee: Gabriel Reid
>             Fix For: 0.5.0
>
>         Attachments: CRUNCH-142_1.patch, CRUNCH-142_2.patch, CRUNCH-142.patch
>
>
> The boolean filter classes AndFn, OrFn and NotFn delegate calls to FilterFn instances internally, but setContext is not called on these first. 
> As a result, methods which need the context such as getCounter() fail with NullPointerException. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira