Return-Path: X-Original-To: apmail-incubator-crunch-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-crunch-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 882DDD79E for ; Wed, 5 Dec 2012 20:36:01 +0000 (UTC) Received: (qmail 74290 invoked by uid 500); 5 Dec 2012 20:36:00 -0000 Delivered-To: apmail-incubator-crunch-dev-archive@incubator.apache.org Received: (qmail 74252 invoked by uid 500); 5 Dec 2012 20:36:00 -0000 Mailing-List: contact crunch-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: crunch-dev@incubator.apache.org Delivered-To: mailing list crunch-dev@incubator.apache.org Received: (qmail 74197 invoked by uid 99); 5 Dec 2012 20:36:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Dec 2012 20:36:00 +0000 Date: Wed, 5 Dec 2012 20:36:00 +0000 (UTC) From: "Josh Wills (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: <1952121639.64741.1354739760564.JavaMail.jiratomcat@arcas> In-Reply-To: <1905156613.60640.1354659058609.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (CRUNCH-124) Javadoc the From, To, and At static methods and add convenience methods for sequenceFiles MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510740#comment-13510740 ] Josh Wills commented on CRUNCH-124: ----------------------------------- @Ashish will do in my next rev. @Gabriel my thinking was that the common case for consuming an Avro file was one where some kind of external schema was already defined and the generated Java code implemented SpecificRecord. To cut down on the number of functions, we could opt to remove the type restrictions on the method and use Avros.records(clazz) to generate the PType, although we'd need the docs to be explicit about what was going on there. Is that your preference? I'm also curious what other Avro users think is the right behavior here. > Javadoc the From, To, and At static methods and add convenience methods for sequenceFiles > ----------------------------------------------------------------------------------------- > > Key: CRUNCH-124 > URL: https://issues.apache.org/jira/browse/CRUNCH-124 > Project: Crunch > Issue Type: Improvement > Components: IO > Reporter: Josh Wills > Attachments: CRUNCH-124.patch > > > Aside from org.apache.crunch.*, the o.a.c.io.(From|To|At) methods are among the most user-facing classes we have. We should javadoc them thoroughly and add more convenience methods that make them easier to get started with for new Crunch users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira