crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Wills (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CRUNCH-137) PTypes.thrift input mapfn shouldn't reference Configuration object
Date Thu, 20 Dec 2012 19:09:12 GMT

     [ https://issues.apache.org/jira/browse/CRUNCH-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Josh Wills resolved CRUNCH-137.
-------------------------------

    Resolution: Fixed
      Assignee: Josh Wills

One-line fix committed.
                
> PTypes.thrift input mapfn shouldn't reference Configuration object
> ------------------------------------------------------------------
>
>                 Key: CRUNCH-137
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-137
>             Project: Crunch
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>             Fix For: 0.5.0
>
>
> The input MapFn in PTypes.thrifts references a Configuration object that may be null,
depending on the context the MapFn is called in. Since a thrift TBase impl does not implement
the Configurable interface, the Configuration object is a no-op and should be excluded from
the initialize() method of the input MapFn, which is the same thing we do for protocol buffers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message