crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Friedrich (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-136) Make WritableType constructor public and FileSourceImpl non-abstract
Date Tue, 18 Dec 2012 19:48:13 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535221#comment-13535221
] 

Matthias Friedrich commented on CRUNCH-136:
-------------------------------------------

I think stuff like this can be committed right away :)
                
> Make WritableType constructor public and FileSourceImpl non-abstract
> --------------------------------------------------------------------
>
>                 Key: CRUNCH-136
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-136
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Josh Wills
>         Attachments: CRUNCH-136.patch
>
>
> Two one-line API fixes:
> 1) The WritableType constructor should be public instead of package-protected, and
> 2) FileSourceImpl should be non-abstract, as it does not have any abstract methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message