crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CRUNCH-117) Custom subclasses of Tuple don't work with the TupleDeepCopier
Date Wed, 21 Nov 2012 20:01:58 GMT

     [ https://issues.apache.org/jira/browse/CRUNCH-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gabriel Reid updated CRUNCH-117:
--------------------------------

    Attachment: CRUNCH-117b.patch

Looks good -- this was actually something that I wasn't sure how to handle back when I did
the deep copying infrastructure, and so I included a bit of javadoc and unit tests that ensured
that this *wouldn't* work.

I've updated the patch a little (and squashed the update together with your commit) to remove
the now-obsolete javadoc, and update the unit test that was supposed to ensure that this situation
would fail.
                
> Custom subclasses of Tuple don't work with the TupleDeepCopier
> --------------------------------------------------------------
>
>                 Key: CRUNCH-117
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-117
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.3.0, 0.4.0
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>             Fix For: 0.5.0
>
>         Attachments: CRUNCH-117b.patch, CRUNCH-117.patch
>
>
> We have the option of serializing custom classes that implement the Tuple interface using
the following method on PTypeFamily:
> PType<T> tuples(Class<T>, ...)
> These classes act somewhat like case classes in Scala, and can be used to give useful
semantics to something that would otherwise be a Tuple4<Integer, String, Double, Integer>
(or some such thing.) Right now, we have a bug in which the static TupleFactory.getTupleFactory
does not recognize these custom classes, and so they can't be used in a nested fashion with
the deep copier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message