crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rahul Sharma (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CRUNCH-93) Crunch core source should not contain packages like o.a.c.test
Date Fri, 12 Oct 2012 16:37:03 GMT

     [ https://issues.apache.org/jira/browse/CRUNCH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rahul Sharma updated CRUNCH-93:
-------------------------------

    Attachment: 0001-CRUNCH-93-moving-test-support-classes.patch

I see that there is lot of testing based code in DoFn and corresponding impls. There are if-
else statements in all the methods there. Plus there is this configurationForTest method that
is callad from all DoFn impls and MemCollections. 
I have removed all of this and created a method to generate TaskIOContext in CrunchTestSupport
based on Mockito, which can be used in unit tests. Also created another proxy based TaskIOcontext
in MemCollection to pass configuration to all DoFns. Also moved the InMemory emitter to o.a.c.mem.emit
package.
                
> Crunch core source should not contain packages like o.a.c.test 
> ---------------------------------------------------------------
>
>                 Key: CRUNCH-93
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-93
>             Project: Crunch
>          Issue Type: Bug
>            Reporter: Rahul Sharma
>            Priority: Minor
>         Attachments: 0001-CRUNCH-93-moving-test-support-classes.patch
>
>
> Crunch core has the following things a package named o.a.c.test and TestCounters class.The
source should not contain test package and classes named with Test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message