crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Friedrich (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-75) Have a method to create Bloom filters in Crunch
Date Wed, 03 Oct 2012 16:26:07 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468650#comment-13468650
] 

Matthias Friedrich commented on CRUNCH-75:
------------------------------------------

Hi Rahul! I meant "git format-patch --find-copies-harder master". I tried that locally and
found the problem: Our shakes.txt has CRLF line endings while the one you add has LF line
endings (which is correct). Without --find-copies-harder, the patch just adds the file, with
--find-copies-harder, the patch makes a copy and then changes line endings on every single
line. So that's bad luck, sorry about the confusion!

As for the patch: Right now it doesn't compile for me, and I'd also put everything in crunch-contrib
into the Java package "org.apache.crunch.contrib" so it's grouped nicely when we create aggregated
Javadoc. Speaking of Javadoc, could you add some, along with a package-info.java file for
o.a.c.contrib and o.a.c.contrib.bloomfilter?
                
> Have a method to create Bloom filters in Crunch
> -----------------------------------------------
>
>                 Key: CRUNCH-75
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-75
>             Project: Crunch
>          Issue Type: New Feature
>            Reporter: Rahul Sharma
>            Assignee: Rahul Sharma
>         Attachments: 0002-Created-crunch-bytes-module-for-users-to-share-funct.patch,
0002-CRUNCH-75-Added-BloomFilters-to-crunch-contrib.patch, CRUNCH-75.patch
>
>
> As per discussion on mailing list, Bloomfilters provide interesting addon to crunch.
But the crunch-core is not the correct place to add such a thing. So create a module i.e.
something along the lines on  piggybank of Pig. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message