Mailing-List: contact crunch-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: crunch-dev@incubator.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAH29n6NS9AzfePMngCoATad2NgwhsO6ohzgUU3JAV0N-4FCgXQ@mail.gmail.com>
References: <3fd46440-f94e-494c-a5c5-1f640d545f96@s6g2000pbi.googlegroups.com>
 <CAH29n6NP3kXLt6zoq7H9_ux-Jky54etd+4c3ombhv_PfQd8GWA@mail.gmail.com>
 <86AEC9345436442F937C7B7D5681F39D@gmail.com>
 <CAGNdOEX=o1bR9=0Crhxqc8=_AsiKRhG-qsqUM_R-ScQduBpKeg@mail.gmail.com>
 <CAH29n6NS9AzfePMngCoATad2NgwhsO6ohzgUU3JAV0N-4FCgXQ@mail.gmail.com>
From: Patrick Hunt <phunt@apache.org>
Date: Mon, 18 Jun 2012 23:08:20 -0700
Message-ID: 
 <CANLc_9Ky7KEtqVC=-XJ5Ajrbn-yOJ5Lg+QU5aCELtjmG=s2uUg@mail.gmail.com>
Subject: Re: Checkstyle & Reviews
To: crunch-dev@incubator.apache.org, Tom White <tomwhite@apache.org>
Cc: Christian Tzolov <christian.tzolov@gmail.com>,
 Gabriel Reid <gabriel.reid@gmail.com>,
	Robert Chu <robert@wibidata.com>, Crunch Dev <crunch-dev@cloudera.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

I'm not a pmc chair, Tom can do it though. Send him the list of apache
ids you want to allow job creation/editing (ie admin).

Patrick

On Mon, Jun 18, 2012 at 8:07 AM, Josh Wills <jwills@cloudera.com> wrote:
> +phunt
>
> http://wiki.apache.org/general/Jenkins
>
> I think Patrick can set us up with Jenkins.
>
> Can we check in the Eclipse style config? And is it possible to
> integrate it w/mvn eclipse:eclipse so that it automatically gets added
> to the project? (I haven't used them before, obviously.)
>
> J
>
> On Sun, Jun 17, 2012 at 11:42 PM, Christian Tzolov
> <christian.tzolov@gmail.com> wrote:
>> +1 for shared eclipse code style configuration
>>
>> IMO using code quality tools as maven plugins is=A0inefficient=A0and har=
d to
>> maintain. More consistent and complete solution would be use Hudson or
>> Jenkins. Not sure though if apache provides such CI tools?
>>
>>
>> On Sat, Jun 16, 2012 at 10:27 AM, Gabriel Reid <gabriel.reid@gmail.com>
>> wrote:
>>>
>>> +1 for a style guide and/or formatting rules and coding rules.
>>>
>>> For code style, something that I've seen work well (at least if everyon=
e
>>> is using Eclipse) is to just have a shared code style definition that y=
ou
>>> can import into Eclipse, and then set Eclipse to apply that style whene=
ver
>>> you save a file. This works great if everyone uses the same style
>>> definition, and breaks down rapidly if they don't.
>>>
>>> I don't have any experience using the maven-findbugs-plugin, but I do f=
ind
>>> the Checkstyle useful, as long as the settings are sane (which is not a=
lways
>>> the case).
>>>
>>> On Saturday 16 June 2012 at 00:17, Josh Wills wrote:
>>>
>>> > I'm in favor of a style guide; consistent layout makes it easier for
>>> > my brain to devour code. That said, I'm not up-to-date on best
>>> > practices here in the real world; my only experience with automated
>>> > code review tools was at teh goog.
>>> >
>>> > Re: code reviews, let's start that discussion up in another thread.
>>> >
>>> > J
>>> >
>>> > On Fri, Jun 15, 2012 at 3:13 PM, Robert Chu <robert@wibidata.com
>>> > (mailto:robert@wibidata.com)> wrote:
>>> > > Hey Everybody,
>>> > >
>>> > > I'd like to start a discussion about using automated code review to=
ols
>>> > > to improve the crunch development process. I'd I'm personally a big
>>> > > fan of using tools that can help improve code quality. These tools
>>> > > often include things like the maven-checkstyle-plugin and the maven=
-
>>> > > findbugs-plugin. I am currently unaware of any comparable scala
>>> > > automated tools. If people have opinions on whether or not we shoul=
d
>>> > > use tools like this or which tools we should be using specifically
>>> > > please let us know.
>>> > >
>>> > > Also, another related question: Should we have some sort of a code
>>> > > review process?
>>> > >
>>> > > Robert Chu
>>> >
>>> >
>>> >
>>> > --
>>> > Director of Data Science
>>> > Cloudera
>>> > Twitter: @josh_wills
>>>
>>>
>>
>
>
>
> --
> Director of Data Science
> Cloudera
> Twitter: @josh_wills