Return-Path: X-Original-To: apmail-crunch-commits-archive@www.apache.org Delivered-To: apmail-crunch-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C644F11CF2 for ; Tue, 19 Aug 2014 17:49:25 +0000 (UTC) Received: (qmail 89103 invoked by uid 500); 19 Aug 2014 17:49:14 -0000 Delivered-To: apmail-crunch-commits-archive@crunch.apache.org Received: (qmail 89074 invoked by uid 500); 19 Aug 2014 17:49:14 -0000 Mailing-List: contact commits-help@crunch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@crunch.apache.org Delivered-To: mailing list commits@crunch.apache.org Received: (qmail 89061 invoked by uid 99); 19 Aug 2014 17:49:14 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Aug 2014 17:49:14 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id ECF0B8BF97F; Tue, 19 Aug 2014 17:49:13 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: jwills@apache.org To: commits@crunch.apache.org Message-Id: <277628242bc142579e4036c3e926ec50@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: git commit: CRUNCH-463: Don't copy the Configuration object during CrunchInputSplit initialization Date: Tue, 19 Aug 2014 17:49:13 +0000 (UTC) Repository: crunch Updated Branches: refs/heads/apache-crunch-0.8 a98c0e5d5 -> 74f512ccb CRUNCH-463: Don't copy the Configuration object during CrunchInputSplit initialization Project: http://git-wip-us.apache.org/repos/asf/crunch/repo Commit: http://git-wip-us.apache.org/repos/asf/crunch/commit/74f512cc Tree: http://git-wip-us.apache.org/repos/asf/crunch/tree/74f512cc Diff: http://git-wip-us.apache.org/repos/asf/crunch/diff/74f512cc Branch: refs/heads/apache-crunch-0.8 Commit: 74f512ccb9bc1380e95b004836c3bfd418ee519e Parents: a98c0e5 Author: Josh Wills Authored: Sat Aug 16 10:13:21 2014 -0700 Committer: Josh Wills Committed: Tue Aug 19 10:42:40 2014 -0700 ---------------------------------------------------------------------- .../main/java/org/apache/crunch/impl/mr/run/CrunchInputFormat.java | 2 +- .../main/java/org/apache/crunch/impl/mr/run/CrunchInputSplit.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/crunch/blob/74f512cc/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/CrunchInputFormat.java ---------------------------------------------------------------------- diff --git a/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/CrunchInputFormat.java b/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/CrunchInputFormat.java index 8c173cc..11e1038 100644 --- a/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/CrunchInputFormat.java +++ b/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/CrunchInputFormat.java @@ -64,7 +64,7 @@ public class CrunchInputFormat extends InputFormat { // and Mapper types by wrapping in a TaggedInputSplit. List pathSplits = format.getSplits(jobCopy); for (InputSplit pathSplit : pathSplits) { - splits.add(new CrunchInputSplit(pathSplit, inputBundle, nodeIndex, conf)); + splits.add(new CrunchInputSplit(pathSplit, inputBundle, nodeIndex, jobCopy.getConfiguration())); } } } http://git-wip-us.apache.org/repos/asf/crunch/blob/74f512cc/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/CrunchInputSplit.java ---------------------------------------------------------------------- diff --git a/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/CrunchInputSplit.java b/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/CrunchInputSplit.java index ec255d9..ee54483 100644 --- a/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/CrunchInputSplit.java +++ b/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/CrunchInputSplit.java @@ -55,7 +55,7 @@ class CrunchInputSplit extends InputSplit implements Writable, Configurable, Sup this.inputSplit = inputSplit; this.bundle = bundle; this.nodeIndex = nodeIndex; - this.conf = new Configuration(conf); + this.conf = conf; } @Override