crunch-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gr...@apache.org
Subject git commit: CRUNCH-349 Avoid NPE when logging NPE
Date Tue, 18 Feb 2014 22:28:38 GMT
Repository: crunch
Updated Branches:
  refs/heads/master 9df580739 -> 296abb86c


CRUNCH-349 Avoid NPE when logging NPE


Project: http://git-wip-us.apache.org/repos/asf/crunch/repo
Commit: http://git-wip-us.apache.org/repos/asf/crunch/commit/296abb86
Tree: http://git-wip-us.apache.org/repos/asf/crunch/tree/296abb86
Diff: http://git-wip-us.apache.org/repos/asf/crunch/diff/296abb86

Branch: refs/heads/master
Commit: 296abb86c99a76f74828fbee52c0b2321c28f9de
Parents: 9df5807
Author: Gabriel Reid <greid@apache.org>
Authored: Tue Feb 18 22:23:01 2014 +0100
Committer: Gabriel Reid <greid@apache.org>
Committed: Tue Feb 18 22:23:01 2014 +0100

----------------------------------------------------------------------
 .../src/main/java/org/apache/crunch/impl/mr/run/RTNode.java       | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/crunch/blob/296abb86/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/RTNode.java
----------------------------------------------------------------------
diff --git a/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/RTNode.java b/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/RTNode.java
index f17beb0..5a7949e 100644
--- a/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/RTNode.java
+++ b/crunch-core/src/main/java/org/apache/crunch/impl/mr/run/RTNode.java
@@ -31,7 +31,6 @@ import org.apache.crunch.impl.mr.emit.OutputEmitter;
 import org.apache.crunch.types.Converter;
 import org.apache.crunch.types.PType;
 import org.apache.hadoop.conf.Configuration;
-import org.apache.hadoop.mapreduce.TaskInputOutputContext;
 
 public class RTNode implements Serializable {
 
@@ -99,7 +98,7 @@ public class RTNode implements Serializable {
       fn.process(input, emitter);
     } catch (CrunchRuntimeException e) {
       if (!e.wasLogged()) {
-        LOG.info(String.format("Crunch exception in '%s' for input: %s", nodeName, input.toString()),
e);
+        LOG.info(String.format("Crunch exception in '%s' for input: %s", nodeName, input),
e);
         e.markLogged();
       }
       throw e;


Mime
View raw message