Return-Path: X-Original-To: apmail-creadur-dev-archive@www.apache.org Delivered-To: apmail-creadur-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AFC2B185EB for ; Tue, 16 Feb 2016 12:10:18 +0000 (UTC) Received: (qmail 53531 invoked by uid 500); 16 Feb 2016 12:10:18 -0000 Delivered-To: apmail-creadur-dev-archive@creadur.apache.org Received: (qmail 53486 invoked by uid 500); 16 Feb 2016 12:10:18 -0000 Mailing-List: contact dev-help@creadur.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@creadur.apache.org Delivered-To: mailing list dev@creadur.apache.org Received: (qmail 53475 invoked by uid 99); 16 Feb 2016 12:10:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Feb 2016 12:10:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 22BFB2C14F2 for ; Tue, 16 Feb 2016 12:10:18 +0000 (UTC) Date: Tue, 16 Feb 2016 12:10:18 +0000 (UTC) From: "Konstantin Kolinko (JIRA)" To: dev@creadur.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (RAT-211) Generated rat-output.xml must be well-formed, even if BinaryGuesser fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/RAT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Kolinko updated RAT-211: ----------------------------------- Description: This issue was originally reported by Infrastructure team while running RAT over Apache Tomcat source code, see thread "Files to exclude from buildbot rat tests" (started 2016-02-15) at dev "at" tomcat.apache.org mailing list. (1) The issue: =========== 1. Buildbot at ASF is configured to run RAT tool over tomcat-trunk, tomcat-8, tomcat-7 source code. 2. Tomcat has \*.bmp, \*.dia files in its source code (images used by Windows installer, diagrams in documentation) that RAT failed to recognize as binary. 3. RAT generated rat-output.xml file that included header-sample fragments of those *.bmp and *.dia files. Those fragments are actually binary garbage. The result is that a broken XML file was generated. 4. XSLT transformation from rat-output.xml into rat-output.html failed. I have not seen the actual error printed by XSLT processor, but I confirmed that the file is broken by downloading rat-output.xml and opening it in Firefox. Firefox reported a syntax error. Workaround: =========== rat-excludes.txt file in Tomcat source code was updated to exclude \*\*/\*.bmp \*\*/\*.dia References: =========== 1. "Files to exclude from buildbot rat tests" (started 2016-02-15) at dev "at" tomcat.apache.org mailing list. http://markmail.org/message/rhrm54ch5omjalt4 2. Apache Tomcat links to Buildbot resuls: http://tomcat.apache.org/ci.html#Buildbot 3. Apache Tomcat source code http://tomcat.apache.org/svn.html Notes: - RAT excludes files in Tomcat source code are at res/rat/rat-excludes.txt - I know that Buildbot uses Ant to run RAT. The Ant project file for that is not in Tomcat sources, but in Infrastructure configuration (I do not have a link). It can be seen in "shell_5 RAT Report Complete" step during build run. E.g. here: https://ci.apache.org/builders/tomcat-trunk/builds/1061 - I do not know what version of RAT is used by that build slave on Buildbot. was: This issue was originally reported by Infrastructure team while running RAT over Apache Tomcat source code, see thread "Files to exclude from buildbot rat tests" (started 2016-02-15) at dev "at" tomcat.apache.org mailing list. (1) The issue: =========== 1. Buildbot at ASF is configured to run RAT tool over tomcat-trunk, tomcat-8, tomcat-7 source code. 2. Tomcat has *.bmp, *.dia files in its source code (images used by Windows installer, diagrams in documentation) that RAT failed to recognize as binary. 3. RAT generated rat-output.xml file that included header-sample fragments of those *.bmp and *.dia files. Those fragments are actually binary garbage. The result is that a broken XML file was generated. 4. XSLT transformation from rat-output.xml into rat-output.html failed. I have not seen the actual error printed by XSLT processor, but I confirmed that the file is broken by downloading rat-output.xml and opening it in Firefox. Firefox reported a syntax error. Workaround: =========== rat-excludes.txt file in Tomcat source code was updated to exclude **/*.bmp **/*.dia References: =========== 1. "Files to exclude from buildbot rat tests" (started 2016-02-15) at dev "at" tomcat.apache.org mailing list. http://markmail.org/message/rhrm54ch5omjalt4 2. Apache Tomcat links to Buildbot resuls: http://tomcat.apache.org/ci.html#Buildbot 3. Apache Tomcat source code http://tomcat.apache.org/svn.html Notes: - RAT excludes files in Tomcat source code are at res/rat/rat-excludes.txt - I know that Buildbot uses Ant to run RAT. The Ant project file for that is not in Tomcat sources, but in Infrastructure configuration (I do not have a link). It can be seen in "shell_5 RAT Report Complete" step during build run. E.g. here: https://ci.apache.org/builders/tomcat-trunk/builds/1061 - I do not know what version of RAT is used by that build slave on Buildbot. > Generated rat-output.xml must be well-formed, even if BinaryGuesser fails > ------------------------------------------------------------------------- > > Key: RAT-211 > URL: https://issues.apache.org/jira/browse/RAT-211 > Project: Apache Rat > Issue Type: Bug > Reporter: Konstantin Kolinko > Attachments: rat-output.xml > > > This issue was originally reported by Infrastructure team while running RAT over Apache Tomcat source code, see thread > "Files to exclude from buildbot rat tests" (started 2016-02-15) at dev "at" tomcat.apache.org mailing list. (1) > The issue: > =========== > 1. Buildbot at ASF is configured to run RAT tool over tomcat-trunk, tomcat-8, tomcat-7 source code. > 2. Tomcat has \*.bmp, \*.dia files in its source code (images used by Windows installer, diagrams in documentation) that RAT failed to recognize as binary. > 3. RAT generated rat-output.xml file that included header-sample fragments of those *.bmp and *.dia files. Those fragments are actually binary garbage. The result is that a broken XML file was generated. > 4. XSLT transformation from rat-output.xml into rat-output.html failed. > I have not seen the actual error printed by XSLT processor, but I confirmed that the file is broken by downloading rat-output.xml and opening it in Firefox. Firefox reported a syntax error. > Workaround: > =========== > rat-excludes.txt file in Tomcat source code was updated to exclude > \*\*/\*.bmp > \*\*/\*.dia > References: > =========== > 1. "Files to exclude from buildbot rat tests" (started 2016-02-15) at dev "at" tomcat.apache.org mailing list. > http://markmail.org/message/rhrm54ch5omjalt4 > 2. Apache Tomcat links to Buildbot resuls: > http://tomcat.apache.org/ci.html#Buildbot > 3. Apache Tomcat source code > http://tomcat.apache.org/svn.html > Notes: > - RAT excludes files in Tomcat source code are at > res/rat/rat-excludes.txt > - I know that Buildbot uses Ant to run RAT. The Ant project file for that is not in Tomcat sources, but in Infrastructure configuration (I do not have a link). It can be seen in "shell_5 RAT Report Complete" step during build run. E.g. here: > https://ci.apache.org/builders/tomcat-trunk/builds/1061 > - I do not know what version of RAT is used by that build slave on Buildbot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)