creadur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [jira] [Created] (RAT-209) Ignore short files when checking licenses
Date Fri, 13 Nov 2015 12:10:17 GMT
On 12 November 2015 at 18:41, P. Ottlinger <pottlinger@apache.org> wrote:
> Hi,
>
> Am 12.11.2015 um 16:39 schrieb Sebb (JIRA):
>> Sebb created RAT-209:
>> ------------------------
>> A license header is not usually required for short files that have no creative content.
>
> I do not really think that this feature is that useful since it adds
> some unclear "guessing" to the otherwise deterministic RAT runs ....

It is fully deterministic. No guessing needed.
The config would specify what criterion to use, e.g.  less than 80 chars.

> what if we miss important files with that fuzzy rule?!

The intention was not to ignore the files completely, just to ignore
them when listing the files without headers.

If a file does not pass the AL check, then see if it is short, and if
so, either report it in a separate section for files that don't need
AL headers.
Or report it with a different tag, e.g. NA.

It's not possible to "miss" files with that approach.

> If you insist on adding it I'd make it optionally configurable.

Yes, it needs to be optional.

> Furthermore I'd prefer to add it after integration Apache Tika to detect
> the type of contents that is scanned ....

It is orthogonal to that, and likely much simpler to add.

> Just my 2ct
>
> Phil

Mime
View raw message