creadur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "P. Ottlinger" <pottlin...@apache.org>
Subject Re: Build failed in Jenkins: Creadur-Rat #290 / RAT-208
Date Sun, 27 Sep 2015 17:56:54 GMT
Hi *,

Am 27.09.2015 um 17:03 schrieb Apache Jenkins Server:
> See <https://builds.apache.org/job/Creadur-Rat/290/changes>
> 
> Changes:
> 
> [jochen] PR: RAT-208
> 
> Added includesFile, excludesFile, includesFileCharacterset, and excludesFileCharacterset
parameters,
> and support thereof.


Do we really need this parameter? I'd assume the exclude/include-File to
have the same encoding as the environment in which RAT runs.

At the moment we have lots of encoding leaks, thus I'd not want to add
explicit parameters to each possibility of different encodings ....

AFAIK we never used the changes.xml but only added new features to the
RELEASE_NOTES.txt file ....

Apart from that I think that AbstractRatMojo should not contain a method
to parse files .... if I'm not too mistaken I used the same
functionality to parse gitignore files - there must be a utility class
somewhere :-)

Cheers,
Phil

Mime
View raw message