Mailing-List: contact dev-help@creadur.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@creadur.apache.org
Date: Wed, 15 Apr 2015 21:39:58 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: dev@creadur.apache.org
Message-ID: <JIRA.12737345.1409218034000.13285.1429133998855@Atlassian.JIRA>
In-Reply-To: <JIRA.12737345.1409218034000@Atlassian.JIRA>
References: <JIRA.12737345.1409218034000@Atlassian.JIRA>
 <JIRA.12737345.1409218034613@arcas>
Subject: [jira] [Commented] (RAT-171) Allow exclude patterns to be read from
 a file or files
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497060#comment-14497060 ] 

Christopher Tubbs commented on RAT-171:
---------------------------------------

Those examples are not Java regular expressions. That's globbing syntax (with globstar) and, as far as I'm aware, are only built into Java in Java 7 and later, using the new {{java.nio.file.FileSystem.getPathMatcher(String)}}.

I don't want to be a contrarian. I think the functionality is helpful. I was just hoping to address some of the shortfalls to the implementation (by constructively asking questions to help identify those shortfalls) prior to it being released. I'll file follow-on bugs if these shortcomings make it into a release, but first I need to understand where the problems could be.

It seems the issue of exclude patterns from files is a very different function than exclude patterns from SCM ignores, and the current implementation does not satisfy SCM ignores very well, even though its configuration represents itself as such.

> Allow exclude patterns to be read from a file or files
> ------------------------------------------------------
>
>                 Key: RAT-171
>                 URL: https://issues.apache.org/jira/browse/RAT-171
>             Project: Apache Rat
>          Issue Type: New Feature
>    Affects Versions: 0.11
>            Reporter: Ignasi Barrera
>            Assignee: Philipp Ottlinger
>             Fix For: 0.12
>
>         Attachments: RAT-171.patch
>
>
> h3. Context
> The apache-rat-plugin ignores by default the .gitignore files. However, for every file/pattern added to those files, an explicit exclusion must be set in the plugin's configuration.
> Given that git-ignored files won't be uploaded to the SCM and shouldn't be part of a release, it would be nice that the apache-rat-plugin automatically considered those git-ignored files as implicit exclusions.
> h3. Implemented for 
> Currently implemented for the following soure code management systems:
> * SVN
> * Git
> * Bazaar
> * Mercurial and 
> * CVS.
> h3. Example usage
> You can configure parsing SCM ignore files by a environment variable 
> {code}
> mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
> {code}
> or in your configuration section of apache-rat-maven plugin 
> {code}
> <parseSCMIgnoresAsExcludes>true</true>
> {code}
> This features is enabled by default.
> In case you want to speed up the build you may disable it and set it to 
> {code}
> false
> {code}
> .


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)