Return-Path: X-Original-To: apmail-creadur-dev-archive@www.apache.org Delivered-To: apmail-creadur-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0C72717242 for ; Tue, 24 Feb 2015 06:55:07 +0000 (UTC) Received: (qmail 39657 invoked by uid 500); 24 Feb 2015 06:55:04 -0000 Delivered-To: apmail-creadur-dev-archive@creadur.apache.org Received: (qmail 39618 invoked by uid 500); 24 Feb 2015 06:55:03 -0000 Mailing-List: contact dev-help@creadur.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@creadur.apache.org Delivered-To: mailing list dev@creadur.apache.org Received: (qmail 39607 invoked by uid 99); 24 Feb 2015 06:55:03 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Feb 2015 06:55:03 +0000 Received: from [192.168.0.33] (e178001160.adsl.alicedsl.de [85.178.1.160]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 2C7651A0421 for ; Tue, 24 Feb 2015 06:55:02 +0000 (UTC) Message-ID: <54EC2005.6000907@apache.org> Date: Tue, 24 Feb 2015 07:53:57 +0100 From: "P. Ottlinger" MIME-Version: 1.0 To: dev@creadur.apache.org Subject: Re: RAT-190 - default encoding UTF-8 / patch / what should be implemented? References: <54E3C7D3.2040400@apache.org> <54EB8E0C.4040304@apache.org> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qaOe6MjNPmN481DUqwICMuWR6mO6Mrh4I" --qaOe6MjNPmN481DUqwICMuWR6mO6Mrh4I Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi *, Am 24.02.2015 um 00:53 schrieb sebb: >>> >> The only change, that I'd be in favour of would be to enforce an >>> >> explicit encoding. Or, in other words, throw an exception, if an >>> >> encoding (aka charset) isn't explicitly choosen. >> > >> > What do you think of adding two more configuration options in the >> > mvn-plugin: >> > >> > defaultLocale - defaults to Locale.US > Why US? > What is the Locale used for? > And why should it differ from the user's Locale? I chose Locale.US since it is hard-coded into RAT at the moment. UTF-8 seems fine to me for most modern operating systems. Please verify the current behaviour of RAT with the test project attached at RAT-190. In case you do not want any defaults/changes how can we make RAT more encoding-aware to give a user a hint that his encoding configuration may be faulty?! Cheers, Phil --qaOe6MjNPmN481DUqwICMuWR6mO6Mrh4I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJU7CBEAAoJEJyMiS+R+ObRCl8P/0+19ssxuC4OvKZJITUz1A8C +8D0LIRBbiqwo5aZq2MDbJy+bbWpvLOVU1dwUQW/5WGwmWa99Jq6+ooTneHMQxX5 4p3Ug9E5brywDJ8xeepzAunlibP8Moc/RShBzCFxqSWyFt4NwSrbza9ngEeKLDfo 44b+qW/qGwVQBxaJktRDTqYOCyvqlAZ8cBg4Kdl6PxOgO8eCXiA+ImsGuM4DA7W5 abLW/aTgHib6UafxUy1MPOvL7tXGFWbssEmNAjEXFUet40H6ycvmXuZYphZt/ZGY r+SPl/AAygGjPRQdvSeHiZkkoyOnp+CoIwcU+IQ145Bl4YA3opwbKJTEuOGoXKG+ pHUeE+bfZA2NCTdJ1BjWIgLs6I2jG387Rk0+b7rVsck+6Uxk+zIaHC/PR/BLyKSo e6JbQHiy4JqIF/lrwQX16Ppi4gOP6KRtN/y0nwk2cjvTYt1KCuBSo1xoBSkMkvdO R+whbkRWbjG3KRlbE8dRp915YZVWoYWR6LoF/OM07de26KV4sM7qBZj7DgQax08j LxVxkGAPbrnawxBCiVaT8kjOK57JCnHxCB95cq6wgwApOcSoGa5cn1RS0vhFs0hM 83hO/MxfA2VKNhv9nGcAfM3F18bbNbgJDPMVVSNiVePWjjI77KFT2AYC6Ep28nI5 M7/xxJYjdC9uPXr+z1EE =zR31 -----END PGP SIGNATURE----- --qaOe6MjNPmN481DUqwICMuWR6mO6Mrh4I--