Return-Path: X-Original-To: apmail-creadur-dev-archive@www.apache.org Delivered-To: apmail-creadur-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7829E1091D for ; Tue, 17 Feb 2015 23:00:54 +0000 (UTC) Received: (qmail 87776 invoked by uid 500); 17 Feb 2015 23:00:32 -0000 Delivered-To: apmail-creadur-dev-archive@creadur.apache.org Received: (qmail 87730 invoked by uid 500); 17 Feb 2015 23:00:32 -0000 Mailing-List: contact dev-help@creadur.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@creadur.apache.org Delivered-To: mailing list dev@creadur.apache.org Received: (qmail 87719 invoked by uid 99); 17 Feb 2015 23:00:32 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Feb 2015 23:00:32 +0000 Received: from [192.168.0.33] (e178020057.adsl.alicedsl.de [85.178.20.57]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 92FEA1A039A for ; Tue, 17 Feb 2015 23:00:31 +0000 (UTC) Message-ID: <54E3C7D3.2040400@apache.org> Date: Tue, 17 Feb 2015 23:59:31 +0100 From: "P. Ottlinger" MIME-Version: 1.0 To: dev@creadur.apache.org Subject: RAT-190 - default encoding UTF-8 / patch / what should be implemented? Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qGWtxdPuHF19177KKqppb4WnkGkEXL4f7" --qGWtxdPuHF19177KKqppb4WnkGkEXL4f7 Content-Type: multipart/mixed; boundary="------------080202070004070605050906" This is a multi-part message in MIME format. --------------080202070004070605050906 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi *, after finalizing the analysis on https://issues.apache.org/jira/browse/RAT-190 it seems that RAT is not explicit enough when it comes to encoding. CAUSE/BUG BACKGROUND If mvn is configured to run with a non UTF-8 encoding there will be problems when matching UTF-8 content with licenses. PATCH PROPOSAL I've browsed over some of the code parts and added some "UTF-8" to make it more explicit that UTF-8 should be the default. What do you think of that proposal? YOU FEEDBACK WANTED 1) Is it sufficient enough? 2a) Should we have a RAT configuration option to allow specific setting of encodings? With UTF-8 as default if not configured/set otherwise. 2) Should we just use UTF-8 as default (hardcoded) and do not give the user a chance to set the encoding to use. IMPROVE TESTABILITY? Since we seem to run with UTF-8 encoding in Jenkins we did not see these problems before. Does anyone have a good idea on how to test this? A UTF-8 encoded file should be analysed with mvn -Dfile.encoding!=3DUTF-8= ? Cheers & thanks for any opinions :-) Phil --------------080202070004070605050906 Content-Type: text/plain; charset=UTF-8; name="20150217proposedPatchForEncoding-RAT190.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="20150217proposedPatchForEncoding-RAT190.txt" SW5kZXg6IGFwYWNoZS1yYXQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcmF0L2Rv Y3VtZW50L2ltcGwvQXJjaGl2ZUVudHJ5RG9jdW1lbnQuamF2YQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBhcGFjaGUtcmF0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JhdC9kb2N1bWVu dC9pbXBsL0FyY2hpdmVFbnRyeURvY3VtZW50LmphdmEJKFJldmlzaW9uIDE2NTk5MzMpCisr KyBhcGFjaGUtcmF0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JhdC9kb2N1bWVu dC9pbXBsL0FyY2hpdmVFbnRyeURvY3VtZW50LmphdmEJKEFyYmVpdHNrb3BpZSkKQEAgLTE5 LDYgKzE5LDEwIEBACiAKIHBhY2thZ2Ugb3JnLmFwYWNoZS5yYXQuZG9jdW1lbnQuaW1wbDsK IAoraW1wb3J0IG9yZy5hcGFjaGUucmF0LmFwaS5Eb2N1bWVudDsKK2ltcG9ydCBvcmcuYXBh Y2hlLnJhdC5hcGkuTWV0YURhdGE7CitpbXBvcnQgb3JnLmFwYWNoZS5yYXQuYXBpLlJhdEV4 Y2VwdGlvbjsKKwogaW1wb3J0IGphdmEuaW8uQnl0ZUFycmF5SW5wdXRTdHJlYW07CiBpbXBv cnQgamF2YS5pby5GaWxlOwogaW1wb3J0IGphdmEuaW8uSU9FeGNlcHRpb247CkBAIC0yNiwx MCArMzAsNiBAQAogaW1wb3J0IGphdmEuaW8uSW5wdXRTdHJlYW1SZWFkZXI7CiBpbXBvcnQg amF2YS5pby5SZWFkZXI7CiAKLWltcG9ydCBvcmcuYXBhY2hlLnJhdC5hcGkuRG9jdW1lbnQ7 Ci1pbXBvcnQgb3JnLmFwYWNoZS5yYXQuYXBpLk1ldGFEYXRhOwotaW1wb3J0IG9yZy5hcGFj aGUucmF0LmFwaS5SYXRFeGNlcHRpb247Ci0KIHB1YmxpYyBjbGFzcyBBcmNoaXZlRW50cnlE b2N1bWVudCBpbXBsZW1lbnRzIERvY3VtZW50IHsKIAogICAgIHByaXZhdGUgYnl0ZVtdIGNv bnRlbnRzOwpJbmRleDogYXBhY2hlLXJhdC1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNo ZS9yYXQvZG9jdW1lbnQvaW1wbC9Nb25vbGl0aGljRmlsZURvY3VtZW50LmphdmEKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gYXBhY2hlLXJhdC1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9y YXQvZG9jdW1lbnQvaW1wbC9Nb25vbGl0aGljRmlsZURvY3VtZW50LmphdmEJKFJldmlzaW9u IDE2NTk5MzMpCisrKyBhcGFjaGUtcmF0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hl L3JhdC9kb2N1bWVudC9pbXBsL01vbm9saXRoaWNGaWxlRG9jdW1lbnQuamF2YQkoQXJiZWl0 c2tvcGllKQpAQCAtMTgsNiArMTgsOCBAQAogICovCiBwYWNrYWdlIG9yZy5hcGFjaGUucmF0 LmRvY3VtZW50LmltcGw7CiAKK2ltcG9ydCBvcmcuYXBhY2hlLnJhdC5hcGkuRG9jdW1lbnQ7 CisKIGltcG9ydCBqYXZhLmlvLkZpbGU7CiBpbXBvcnQgamF2YS5pby5GaWxlSW5wdXRTdHJl YW07CiBpbXBvcnQgamF2YS5pby5GaWxlUmVhZGVyOwpAQCAtMjcsOSArMjksNyBAQAogaW1w b3J0IGphdmEuaW8uUmVhZGVyOwogaW1wb3J0IGphdmEubmV0LlVSTDsKIAotaW1wb3J0IG9y Zy5hcGFjaGUucmF0LmFwaS5Eb2N1bWVudDsKIAotCiBwdWJsaWMgY2xhc3MgTW9ub2xpdGhp Y0ZpbGVEb2N1bWVudCBleHRlbmRzIEFic3RyYWN0TW9ub2xpdGhpY0RvY3VtZW50IHsKICAg ICBwcml2YXRlIHN0YXRpYyBmaW5hbCBTdHJpbmcgVVRGXzggPSAiVVRGLTgiOwogCkluZGV4 OiBhcGFjaGUtcmF0LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcmF0L21wL0Zp bGVzUmVwb3J0YWJsZS5qYXZhCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGFwYWNoZS1yYXQtcGx1Z2lu L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yYXQvbXAvRmlsZXNSZXBvcnRhYmxlLmphdmEJ KFJldmlzaW9uIDE2NTk5MzMpCisrKyBhcGFjaGUtcmF0LXBsdWdpbi9zcmMvbWFpbi9qYXZh L29yZy9hcGFjaGUvcmF0L21wL0ZpbGVzUmVwb3J0YWJsZS5qYXZhCShBcmJlaXRza29waWUp CkBAIC04Niw3ICs4Niw3IEBACiAgICAgICAgIHB1YmxpYyBSZWFkZXIgcmVhZGVyKCkgdGhy b3dzIElPRXhjZXB0aW9uCiAgICAgICAgIHsKICAgICAgICAgICAgIGZpbmFsIElucHV0U3Ry ZWFtIGluID0gbmV3IEZpbGVJbnB1dFN0cmVhbSggZmlsZSApOwotICAgICAgICAgICAgcmV0 dXJuIG5ldyBJbnB1dFN0cmVhbVJlYWRlciggaW4gKTsKKyAgICAgICAgICAgIHJldHVybiBu ZXcgSW5wdXRTdHJlYW1SZWFkZXIoIGluICwgIlVURi04Iik7CiAgICAgICAgIH0KIAogICAg ICAgICBwdWJsaWMgU3RyaW5nIGdldE5hbWUoKQpJbmRleDogYXBhY2hlLXJhdC10YXNrcy9z cmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcmF0L2FudHRhc2tzL1Jlc291cmNlQ29sbGVjdGlv bkNvbnRhaW5lci5qYXZhCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGFwYWNoZS1yYXQtdGFza3Mvc3Jj L21haW4vamF2YS9vcmcvYXBhY2hlL3JhdC9hbnR0YXNrcy9SZXNvdXJjZUNvbGxlY3Rpb25D b250YWluZXIuamF2YQkoUmV2aXNpb24gMTY1OTkzMykKKysrIGFwYWNoZS1yYXQtdGFza3Mv c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JhdC9hbnR0YXNrcy9SZXNvdXJjZUNvbGxlY3Rp b25Db250YWluZXIuamF2YQkoQXJiZWl0c2tvcGllKQpAQCAtMTgsMTMgKzE4LDYgQEAKICAq LyAKIHBhY2thZ2Ugb3JnLmFwYWNoZS5yYXQuYW50dGFza3M7CiAKLWltcG9ydCBqYXZhLmlv LkZpbGU7Ci1pbXBvcnQgamF2YS5pby5JT0V4Y2VwdGlvbjsKLWltcG9ydCBqYXZhLmlvLklu cHV0U3RyZWFtOwotaW1wb3J0IGphdmEuaW8uSW5wdXRTdHJlYW1SZWFkZXI7Ci1pbXBvcnQg amF2YS5pby5SZWFkZXI7Ci1pbXBvcnQgamF2YS51dGlsLkl0ZXJhdG9yOwotCiBpbXBvcnQg b3JnLmFwYWNoZS5yYXQuYXBpLkRvY3VtZW50OwogaW1wb3J0IG9yZy5hcGFjaGUucmF0LmFw aS5NZXRhRGF0YTsKIGltcG9ydCBvcmcuYXBhY2hlLnJhdC5hcGkuUmF0RXhjZXB0aW9uOwpA QCAtMzUsNiArMjgsMTMgQEAKIGltcG9ydCBvcmcuYXBhY2hlLnRvb2xzLmFudC50eXBlcy5S ZXNvdXJjZUNvbGxlY3Rpb247CiBpbXBvcnQgb3JnLmFwYWNoZS50b29scy5hbnQudHlwZXMu cmVzb3VyY2VzLkZpbGVSZXNvdXJjZTsKIAoraW1wb3J0IGphdmEuaW8uRmlsZTsKK2ltcG9y dCBqYXZhLmlvLklPRXhjZXB0aW9uOworaW1wb3J0IGphdmEuaW8uSW5wdXRTdHJlYW07Citp bXBvcnQgamF2YS5pby5JbnB1dFN0cmVhbVJlYWRlcjsKK2ltcG9ydCBqYXZhLmlvLlJlYWRl cjsKK2ltcG9ydCBqYXZhLnV0aWwuSXRlcmF0b3I7CisKIC8qKgogICogSW1wbGVtZW50YXRp b24gb2YgSVJlcG9ydGFibGUgdGhhdCB0cmF2ZXJzZXMgb3ZlciBhIHJlc291cmNlCiAgKiBj b2xsZWN0aW9uIGludGVybmFsbHkuCkBAIC02OCw3ICs2OCw3IEBACiAgICAgICAgIAogICAg ICAgICBwdWJsaWMgUmVhZGVyIHJlYWRlcigpIHRocm93cyBJT0V4Y2VwdGlvbiB7CiAgICAg ICAgICAgICBmaW5hbCBJbnB1dFN0cmVhbSBpbiA9IHJlc291cmNlLmdldElucHV0U3RyZWFt KCk7Ci0gICAgICAgICAgICBmaW5hbCBSZWFkZXIgcmVzdWx0ID0gbmV3IElucHV0U3RyZWFt UmVhZGVyKGluKTsKKyAgICAgICAgICAgIGZpbmFsIFJlYWRlciByZXN1bHQgPSBuZXcgSW5w dXRTdHJlYW1SZWFkZXIoaW4sICJVVEYtOCIpOwogICAgICAgICAgICAgcmV0dXJuIHJlc3Vs dDsKICAgICAgICAgfQogCg== --------------080202070004070605050906-- --qGWtxdPuHF19177KKqppb4WnkGkEXL4f7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJU48gMAAoJEJyMiS+R+ObRtKwQAJ8T9tkioQmmKLXqk7lGXdes 4h96JqeKpJIMZt8TBxqZkFBQK1TvWNeisKgZO76eC/N3zoKtEnUKwHevneZR4WDu 0uod+51H9rm/bchS5PpRMJ+eQUsZjODqTvXSdqef1VYb9Fys8qB4Rmur2aPuDRVB QmrtcNWasz7D7e+AUWjFXHh2AhWmfHTvL7eGPKO9hCttCysTKf8RI8I1qudN/q4f atJgXwLBCxiZQai8Jld2YQATJMhHPnIc3Lalf4Iy23mzj6aHUP2dW2okYSQSgni0 KcEc+pAiuWYhEco9tyY6Dh6yh4jnTnIbBzfOl29Ll/6v6T1nifrQH/JgP7uKwKHq qUfz3iR3NTVJ4xUXzO+7UIvlrDvO0bNpRjBCo2DpZHZXIyvyXxhzUetv+WPMJkL4 zKOCLw1B4naUlMv/1nXfGe9/QmLoESYzPKJNvNmPZWziiPMSmz/E6wPdNx4r6sES U4KQH2i9xjxxS//suI8L19n70sm4vO7p3qhLNHdPYVVFyoxbxVPYrp2DjCMz+AE9 bNV/kpKnsWwgY/3U5ShznHZbiIyHIBGG8WIkLAPs2VYmrxJac+H6YeSZGLpcmGFu dwWdkpkwHmKZDn440exvnefBF/h+XPyGwj4lE5qz9tA9KFZ8AspoZY2eeJgVmXEg DrtIo6JL+abU5gQPOuOZ =zb+z -----END PGP SIGNATURE----- --qGWtxdPuHF19177KKqppb4WnkGkEXL4f7--