creadur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philipp Ottlinger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (RAT-190) False negatives(?) in apache rat license checking
Date Mon, 16 Feb 2015 21:25:11 GMT

    [ https://issues.apache.org/jira/browse/RAT-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323318#comment-14323318
] 

Philipp Ottlinger commented on RAT-190:
---------------------------------------

I'm not sure if that changes anything, but checked the file itself - the JS seems to be UTF-8.
I'm not sure if your operating system handles it correctly during RAT-parsing. Here's the
output of file:
{code}
$ file MailComposeView.js 
MailComposeView.js: UTF-8 Unicode text, with CRLF line terminators
{code}

I meant to change the mvn encoding settings; I assume that the pom's encoding has nothing
to do with the maven encoding if mvn itself is running. Can you manage to get UTF-8 when calling
this:
{code}
$ mvn --version

Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T18:29:23+01:00)
Maven home: /home/user/software/maven
Java version: 1.8.0_31, vendor: Oracle Corporation
Java home: /home/user/jdk1.8.0_31/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "linux", version: "3.13.0-46-generic", arch: "amd64", family: "unix"
{code}
You had this CP-something encoding as platform encoding.

Please also try out if 
{code}
mvn --U -Dfile.encoding=UTF-8
{code}
changes anything.


> False negatives(?) in apache rat license checking
> -------------------------------------------------
>
>                 Key: RAT-190
>                 URL: https://issues.apache.org/jira/browse/RAT-190
>             Project: Apache Rat
>          Issue Type: Bug
>    Affects Versions: 0.8, 0.11
>            Reporter: Dan Dumont
>            Assignee: Philipp Ottlinger
>         Attachments: complete-pom.xml, test.zip
>
>
> We're using rat to enforce our internal copyright on all of our source files.
> We're seeing it missing files that should be flagged.  Here's part of our pom:
> <licenses>
>   <license implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
>     <licenseFamilyCategory>IBMCL</licenseFamilyCategory>
>     <licenseFamilyName>IBM Copyright</licenseFamilyName>
>     <notes></notes>
>     <patterns>
>       <pattern>Copyright IBM Corp. 2015</pattern>
>       <pattern>Copyright IBM Corp. 2014, 2015</pattern>
>       <pattern>Copyright IBM Corp. 2013, 2015</pattern>
>     </patterns>
>   </license>
> </licenses>
> <licenseFamilies>
>   <licenseFamily implementation="org.apache.rat.license.SimpleLicenseFamily">
>   <familyName>IBM Copyright</familyName>
> </licenseFamily>
> </licenseFamilies>
> The file in question is "included" as reported by running with debug output...  but the
file's copyright is:
> /* Copyright IBM Corp. 2014  All Rights Reserved.                    */



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message