creadur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ignasi Barrera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (RAT-171) Allow exclude patterns to be read from a file or files
Date Thu, 28 Aug 2014 21:53:08 GMT

    [ https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114424#comment-14114424
] 

Ignasi Barrera commented on RAT-171:
------------------------------------

Having a deeper look, I think we should leave only the property to configure the "exclusion
files", but do not automatically process the .gitignore and other SCM files.

Those have very specific syntax and allow expressions that might not be compatible with the
rat plugin path matchers. Instead of adding more unnecessary complexity to the plugin, I'd
say that it's better to remove the automatic processing of the ignore files from this patch,
and leave only the property to allow users to configure their custom files (such as the .gitignore).

WDYT?

> Allow exclude patterns to be read from a file or files
> ------------------------------------------------------
>
>                 Key: RAT-171
>                 URL: https://issues.apache.org/jira/browse/RAT-171
>             Project: Apache Rat
>          Issue Type: Improvement
>    Affects Versions: 0.11
>            Reporter: Ignasi Barrera
>            Assignee: Philipp Ottlinger
>         Attachments: RAT-171.patch
>
>
> The apache-rat-plugin ignores by default the .gitignore files. However, for every file/pattern
added to those files, an explicit exclusion must be set in the plugin's configuration.
> Given that git-ignored files won't be uploaded to the SCM and shouldn't be part of a
release, it would be nice that the apache-rat-plugin automatically considered those git-ignored
files as implicit exclusions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message