creadur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ignasi Barrera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (RAT-171) Implicit ignores should include git-ignored files
Date Thu, 28 Aug 2014 13:06:08 GMT

    [ https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113726#comment-14113726
] 

Ignasi Barrera commented on RAT-171:
------------------------------------

IMO it is not a special case. The plugin already adds the {{.gitignore}} file to the list
of exclusions if the {{useDefaultExcludes}} is set (by default the property is set to _true_).
Given that the file is being automatically excluded when that property is set, I think it
does not make sense to run the checks for the ignored files it contains. If the plugin is
already excluding the .gitignore file, I think it should also exclude its contents, and that
does not look like a special case to me.

Regarding the issue title, it was initially intended only for the .gitignore file (the first
patch addressed that), but it makes sense to change it now that the fix is more generic.

> Implicit ignores should include git-ignored files
> -------------------------------------------------
>
>                 Key: RAT-171
>                 URL: https://issues.apache.org/jira/browse/RAT-171
>             Project: Apache Rat
>          Issue Type: Improvement
>    Affects Versions: 0.11
>            Reporter: Ignasi Barrera
>         Attachments: RAT-171.patch
>
>
> The apache-rat-plugin ignores by default the .gitignore files. However, for every file/pattern
added to those files, an explicit exclusion must be set in the plugin's configuration.
> Given that git-ignored files won't be uploaded to the SCM and shouldn't be part of a
release, it would be nice that the apache-rat-plugin automatically considered those git-ignored
files as implicit exclusions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message