Return-Path: 
 <dev-return-2170-apmail-creadur-dev-archive=creadur.apache.org@creadur.apache.org>
X-Original-To: apmail-creadur-dev-archive@www.apache.org
Delivered-To: apmail-creadur-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id BFA4A11EE7
	for <apmail-creadur-dev-archive@www.apache.org>;
 Wed,  9 Jul 2014 12:45:05 +0000 (UTC)
Received: (qmail 47571 invoked by uid 500); 9 Jul 2014 12:45:05 -0000
Delivered-To: apmail-creadur-dev-archive@creadur.apache.org
Received: (qmail 47518 invoked by uid 500); 9 Jul 2014 12:45:05 -0000
Mailing-List: contact dev-help@creadur.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@creadur.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@creadur.apache.org>
List-Post: <mailto:dev@creadur.apache.org>
List-Id: <dev.creadur.apache.org>
Reply-To: dev@creadur.apache.org
Delivered-To: mailing list dev@creadur.apache.org
Received: (qmail 47505 invoked by uid 99); 9 Jul 2014 12:45:05 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2014 12:45:05 +0000
Date: Wed, 9 Jul 2014 12:45:05 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@creadur.apache.org
Message-ID: <JIRA.12533122.1322577836356.7780.1404909905562@arcas>
In-Reply-To: <JIRA.12533122.1322577836356@arcas>
References: <JIRA.12533122.1322577836356@arcas>
Subject: [jira] [Commented] (RAT-107) useEclipseDefaultExcludes does not
 ignore sub-module's eclipse dotfiles.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/RAT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056184#comment-14056184 ] 

ASF GitHub Bot commented on RAT-107:
------------------------------------

Github user richardcloudsoft commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14706993
  
    --- Diff: pom.xml ---
    @@ -678,6 +662,64 @@
                         </execution>
                     </executions>
                 </plugin>
    +            <!-- Needed for command-line access, e.g mvn apache-rat:rat and mvn apache-rat:check -->
    +            <plugin>
    +              <groupId>org.apache.rat</groupId>
    +              <artifactId>apache-rat-plugin</artifactId>
    +              <version>0.10</version>
    +              <executions>
    +                <execution>
    +                  <phase>verify</phase>
    +                  <goals>
    +                    <goal>check</goal>
    +                  </goals>
    +                </execution> 
    +              </executions>
    +              <configuration>
    +                <!--
    +                     If you wish to override this list in the component (child) pom, ensure you use
    +                         <excludes combine.children="merge">
    +                     so that the child pom entries replace the parent entries
    +                 -->
    +                <excludes combine.children="append">
    +                  <!-- git and IDE project files -->
    +                  <!-- see https://issues.apache.org/jira/browse/RAT-107 -->
    +                  <exclude>**/.git/**</exclude>
    +                  <exclude>**/.gitignore</exclude>
    +                  <exclude>**/.idea/**</exclude>
    +                  <exclude>**/*.iml</exclude>
    +                  <exclude>**/.classpath/**</exclude>
    +                  <exclude>**/.project</exclude>
    +                  <exclude>**/.settings/**</exclude>
    +                  <exclude>**/*.log</exclude>
    +                  <exclude>**/brooklyn*.log.*</exclude>
    +                  <!-- files not requiring licence -->
    +                  <exclude>ignored/**</exclude>
    +                  <exclude>LICENSE.md</exclude>
    +                  <exclude>**/MANIFEST.MF</exclude>
    +                  <exclude>**/test-output/**</exclude>
    +                  <exclude>**/*.pem.pub</exclude>
    +                  <exclude>**/*.svg</exclude>
    +                  <exclude>**/*.crt</exclude>
    +                  <exclude>**/*.csr</exclude>
    +                  <exclude>**/*.key</exclude>
    +                  <exclude>**/*.key.org</exclude>
    +                  <exclude>**/*.psd</exclude>
    +                  <exclude>**/*.json</exclude>
    --- End diff --
    
    s/jClouds/jclouds/ `</pedantic>`


> useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles.
> ------------------------------------------------------------------------
>
>                 Key: RAT-107
>                 URL: https://issues.apache.org/jira/browse/RAT-107
>             Project: Apache Rat
>          Issue Type: Bug
>          Components: maven
>    Affects Versions: 0.8
>         Environment: Maven 3.03, Java 1.6.0_29, eclipse Indigo Service release 1
>            Reporter: jv
>              Labels: eclipse, maven
>         Attachments: apache-rat-project-RAT-107.patch
>
>
> useEclipseDefaultExcludes works for ignoring eclipse dotfiles in the parent pom's directory, but when used in conjuction with excludeSubProjects=false, subProjects eclipse dotfiles are not ignored and I believe they should be.
> This can be recreated by having a maven project with integrated submodules, and setting up RAT to <excludeSubProjects>false</excludeSubProjects> and <useEclipseDefaultExcludes>true</useEclipseDefaultExcludes>. In the generated output file you will see the .project and .settings file/folder are not included in the check, but the <submodule>/.project and <submodule>/.settings file/folder are checked (and will presumably fail).



--
This message was sent by Atlassian JIRA
(v6.2#6252)