creadur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (RAT-107) useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles.
Date Wed, 09 Jul 2014 12:12:05 GMT

    [ https://issues.apache.org/jira/browse/RAT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056154#comment-14056154
] 

ASF GitHub Bot commented on RAT-107:
------------------------------------

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14705875
  
    --- Diff: pom.xml ---
    @@ -678,6 +662,64 @@
                         </execution>
                     </executions>
                 </plugin>
    +            <!-- Needed for command-line access, e.g mvn apache-rat:rat and mvn apache-rat:check
-->
    +            <plugin>
    +              <groupId>org.apache.rat</groupId>
    +              <artifactId>apache-rat-plugin</artifactId>
    +              <version>0.10</version>
    +              <executions>
    +                <execution>
    +                  <phase>verify</phase>
    +                  <goals>
    +                    <goal>check</goal>
    +                  </goals>
    +                </execution> 
    +              </executions>
    +              <configuration>
    +                <!--
    +                     If you wish to override this list in the component (child) pom,
ensure you use
    +                         <excludes combine.children="merge">
    +                     so that the child pom entries replace the parent entries
    +                 -->
    +                <excludes combine.children="append">
    +                  <!-- git and IDE project files -->
    +                  <!-- see https://issues.apache.org/jira/browse/RAT-107 -->
    +                  <exclude>**/.git/**</exclude>
    +                  <exclude>**/.gitignore</exclude>
    +                  <exclude>**/.idea/**</exclude>
    +                  <exclude>**/*.iml</exclude>
    +                  <exclude>**/.classpath/**</exclude>
    +                  <exclude>**/.project</exclude>
    +                  <exclude>**/.settings/**</exclude>
    +                  <exclude>**/*.log</exclude>
    +                  <exclude>**/brooklyn*.log.*</exclude>
    +                  <!-- files not requiring licence -->
    +                  <exclude>ignored/**</exclude>
    +                  <exclude>LICENSE.md</exclude>
    +                  <exclude>**/MANIFEST.MF</exclude>
    +                  <exclude>**/test-output/**</exclude>
    +                  <exclude>**/*.pem.pub</exclude>
    +                  <exclude>**/*.svg</exclude>
    +                  <exclude>**/*.crt</exclude>
    +                  <exclude>**/*.csr</exclude>
    +                  <exclude>**/*.key</exclude>
    +                  <exclude>**/*.key.org</exclude>
    +                  <exclude>**/*.psd</exclude>
    +                  <exclude>**/*.json</exclude>
    +                  <exclude>**/*.plxarc</exclude>
    +                  <exclude>**/services/brooklyn.location.LocationResolver</exclude>
    --- End diff --
    
    Presumably these services files could have the comment at the top as well? Not sure if
required. @richardcloudsoft what do you think?


> useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles.
> ------------------------------------------------------------------------
>
>                 Key: RAT-107
>                 URL: https://issues.apache.org/jira/browse/RAT-107
>             Project: Apache Rat
>          Issue Type: Bug
>          Components: maven
>    Affects Versions: 0.8
>         Environment: Maven 3.03, Java 1.6.0_29, eclipse Indigo Service release 1
>            Reporter: jv
>              Labels: eclipse, maven
>         Attachments: apache-rat-project-RAT-107.patch
>
>
> useEclipseDefaultExcludes works for ignoring eclipse dotfiles in the parent pom's directory,
but when used in conjuction with excludeSubProjects=false, subProjects eclipse dotfiles are
not ignored and I believe they should be.
> This can be recreated by having a maven project with integrated submodules, and setting
up RAT to <excludeSubProjects>false</excludeSubProjects> and <useEclipseDefaultExcludes>true</useEclipseDefaultExcludes>.
In the generated output file you will see the .project and .settings file/folder are not included
in the check, but the <submodule>/.project and <submodule>/.settings file/folder
are checked (and will presumably fail).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message