Return-Path: X-Original-To: apmail-creadur-dev-archive@www.apache.org Delivered-To: apmail-creadur-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 414A41133D for ; Tue, 10 Jun 2014 21:21:05 +0000 (UTC) Received: (qmail 16575 invoked by uid 500); 10 Jun 2014 21:21:04 -0000 Delivered-To: apmail-creadur-dev-archive@creadur.apache.org Received: (qmail 16538 invoked by uid 500); 10 Jun 2014 21:21:04 -0000 Mailing-List: contact dev-help@creadur.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@creadur.apache.org Delivered-To: mailing list dev@creadur.apache.org Received: (qmail 16519 invoked by uid 99); 10 Jun 2014 21:21:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jun 2014 21:21:04 +0000 Date: Tue, 10 Jun 2014 21:21:04 +0000 (UTC) From: "Andrew Gaul (JIRA)" To: dev@creadur.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (RAT-162) CDDL1License.matches slow with large inputs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/RAT-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated RAT-162: ---------------------------- Description: mvn apache-rat:check runs slowly with large files. I accidentally had a 100 MB log file which took over a minute to for RAT to parse. The stack trace included: {noformat} "main" prio=10 tid=0x00007f322800a000 nid=0x6730 runnable [0x00007f3230235000] java.lang.Thread.State: RUNNABLE at java.util.regex.Pattern$Curly.match0(Pattern.java:4166) at java.util.regex.Pattern$Curly.match(Pattern.java:4132) at java.util.regex.Pattern$Start.match(Pattern.java:3408) at java.util.regex.Matcher.search(Matcher.java:1199) at java.util.regex.Matcher.find(Matcher.java:592) at org.apache.rat.analysis.license.CDDL1License.matches(CDDL1License.java:65) at org.apache.rat.analysis.license.SimplePatternBasedLicense.match(SimplePatternBasedLicense.java:69) {noformat} I attached a patch which caches the Patterns in CDDL1License which works around this issue. was: mvn apache-rat:check runs slowly with large files. I accidentally had a 100 MB log file which took over a minute to for RAT to parse. The stack trace included: {noformat} "main" prio=10 tid=0x00007f322800a000 nid=0x6730 runnable [0x00007f3230235000] java.lang.Thread.State: RUNNABLE at java.util.regex.Pattern$Curly.match0(Pattern.java:4166) at java.util.regex.Pattern$Curly.match(Pattern.java:4132) at java.util.regex.Pattern$Start.match(Pattern.java:3408) at java.util.regex.Matcher.search(Matcher.java:1199) at java.util.regex.Matcher.find(Matcher.java:592) at org.apache.rat.analysis.license.CDDL1License.matches(CDDL1License.java:65) at org.apache.rat.analysis.license.SimplePatternBasedLicense.match(SimplePatternBasedLicense.java:69) {noformat} I attached a patch which caches the Patterns in CDDL1License works around this issue. > CDDL1License.matches slow with large inputs > ------------------------------------------- > > Key: RAT-162 > URL: https://issues.apache.org/jira/browse/RAT-162 > Project: Apache Rat > Issue Type: Improvement > Affects Versions: 0.10 > Reporter: Andrew Gaul > Fix For: 0.11 > > Attachments: RAT-162.patch > > > mvn apache-rat:check runs slowly with large files. I accidentally had a 100 MB log file which took over a minute to for RAT to parse. The stack trace included: > {noformat} > "main" prio=10 tid=0x00007f322800a000 nid=0x6730 runnable [0x00007f3230235000] > java.lang.Thread.State: RUNNABLE > at java.util.regex.Pattern$Curly.match0(Pattern.java:4166) > at java.util.regex.Pattern$Curly.match(Pattern.java:4132) > at java.util.regex.Pattern$Start.match(Pattern.java:3408) > at java.util.regex.Matcher.search(Matcher.java:1199) > at java.util.regex.Matcher.find(Matcher.java:592) > at org.apache.rat.analysis.license.CDDL1License.matches(CDDL1License.java:65) > at org.apache.rat.analysis.license.SimplePatternBasedLicense.match(SimplePatternBasedLicense.java:69) > {noformat} > I attached a patch which caches the Patterns in CDDL1License which works around this issue. -- This message was sent by Atlassian JIRA (v6.2#6252)