Return-Path: X-Original-To: apmail-creadur-dev-archive@www.apache.org Delivered-To: apmail-creadur-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 107ECDBE9 for ; Sat, 18 May 2013 15:43:16 +0000 (UTC) Received: (qmail 7198 invoked by uid 500); 18 May 2013 15:43:16 -0000 Delivered-To: apmail-creadur-dev-archive@creadur.apache.org Received: (qmail 7162 invoked by uid 500); 18 May 2013 15:43:16 -0000 Mailing-List: contact dev-help@creadur.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@creadur.apache.org Delivered-To: mailing list dev@creadur.apache.org Received: (qmail 7153 invoked by uid 99); 18 May 2013 15:43:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 May 2013 15:43:16 +0000 Date: Sat, 18 May 2013 15:43:16 +0000 (UTC) From: "Sebb (JIRA)" To: dev@creadur.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (RAT-139) FullTextMatchingLicense.prune uses inefficient deleteAtChar MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/RAT-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved RAT-139. ---------------------- Resolution: Fixed URL: http://svn.apache.org/r1484129 Log: RAT-139 FullTextMatchingLicense.prune uses inefficient deleteAtChar Moved prune to BaseLicense class Modified: creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/analysis/license/AppliedApacheSoftwareLicense20.java creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/analysis/license/BaseLicense.java creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/analysis/license/FullTextMatchingLicense.java > FullTextMatchingLicense.prune uses inefficient deleteAtChar > ----------------------------------------------------------- > > Key: RAT-139 > URL: https://issues.apache.org/jira/browse/RAT-139 > Project: Apache Rat > Issue Type: Improvement > Affects Versions: 0.9 > Reporter: Sebb > Fix For: 0.10 > > > FullTextMatchingLicense.prune is quite inefficient. > It first copies the entire string to a StringBuilder, then scans the buffer deleting characters that are not letters or digits. > It should be a lot quicker to just copy the letters and digits once, skipping the rest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira