creadur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (RAT-139) FullTextMatchingLicense.prune uses inefficient deleteAtChar
Date Sat, 18 May 2013 15:43:16 GMT

     [ https://issues.apache.org/jira/browse/RAT-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb resolved RAT-139.
----------------------

    Resolution: Fixed

URL: http://svn.apache.org/r1484129
Log:
RAT-139 FullTextMatchingLicense.prune uses inefficient deleteAtChar
Moved prune to BaseLicense class

Modified:
    creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/analysis/license/AppliedApacheSoftwareLicense20.java
    creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/analysis/license/BaseLicense.java
    creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/analysis/license/FullTextMatchingLicense.java

                
> FullTextMatchingLicense.prune uses inefficient deleteAtChar
> -----------------------------------------------------------
>
>                 Key: RAT-139
>                 URL: https://issues.apache.org/jira/browse/RAT-139
>             Project: Apache Rat
>          Issue Type: Improvement
>    Affects Versions: 0.9
>            Reporter: Sebb
>             Fix For: 0.10
>
>
> FullTextMatchingLicense.prune is quite inefficient.
> It first copies the entire string to a StringBuilder, then scans the buffer deleting
characters that are not letters or digits.
> It should be a lot quicker to just copy the letters and digits once, skipping the rest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message