creadur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <>
Subject [jira] [Commented] (RAT-138) RAT runs very slowly on some input
Date Wed, 15 May 2013 02:17:16 GMT


Sebb commented on RAT-138:

Looking at the code for FullTextMatchingLicense I wonder whether regexes are needed at all?

Only letters and digits are kept from the pattern, so it cannot contain any RE meta-characters.

AFAICT, one could just convert the pattern and text to lower case and then use String.contains()
which is going to be much faster.

> RAT runs very slowly on some input
> ----------------------------------
>                 Key: RAT-138
>                 URL:
>             Project: Apache Rat
>          Issue Type: Bug
>          Components: engine
>    Affects Versions: 0.9
>            Reporter: Sebb
> Commons IO discovered that mvn site was spending a lot of time running RAT 0.9. Reverting
to 0.8 fixes the problem.
> Turns out that certain files seem to cause RAT to chew CPU in the Pattern.matcher; here
is a sample stack trace from a thread dump:
> "main" prio=6 tid=0x003c8c00 nid=0xa4c runnable [0x00a5e000]
>    java.lang.Thread.State: RUNNABLE
>         at java.util.regex.Pattern$Curly.match0(
>         at java.util.regex.Pattern$Curly.match(
>         at java.util.regex.Matcher.match(
>         at java.util.regex.Matcher.matches(
>         at org.apache.rat.analysis.license.FullTextMatchingLicense.match(
>         at org.apache.rat.analysis.util.HeaderMatcherMultiplexer.match(
>         at org.apache.rat.analysis.HeaderCheckWorker.readLine(
>         at
>         at org.apache.rat.analysis.DocumentHeaderAnalyser.analyse(
>         at org.apache.rat.analysis.DefaultAnalyserFactory$DefaultAnalyser.analyse(
>         at org.apache.rat.document.impl.util.DocumentAnalyserMultiplexer.analyse(
>         at
>         at
>         at
>         at
>         at
>         at
>         at
>         at
> I assume there must be a problem with one of the REs which is triggering lots of backtracking
when applied to files under site-content/, which is a working copy of:
> Last Changed Rev: 861378
> This directory should not have been included in the RAT scan, but the files don't cause
problems for RAT 0.8.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message