Return-Path: 
 <dev-return-1577-apmail-creadur-dev-archive=creadur.apache.org@creadur.apache.org>
X-Original-To: apmail-creadur-dev-archive@www.apache.org
Delivered-To: apmail-creadur-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E4E44D505
	for <apmail-creadur-dev-archive@www.apache.org>;
 Fri, 21 Sep 2012 21:44:51 +0000 (UTC)
Received: (qmail 25977 invoked by uid 500); 21 Sep 2012 21:44:51 -0000
Delivered-To: apmail-creadur-dev-archive@creadur.apache.org
Received: (qmail 25913 invoked by uid 500); 21 Sep 2012 21:44:51 -0000
Mailing-List: contact dev-help@creadur.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@creadur.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@creadur.apache.org>
List-Post: <mailto:dev@creadur.apache.org>
List-Id: <dev.creadur.apache.org>
Reply-To: dev@creadur.apache.org
Delivered-To: mailing list dev@creadur.apache.org
Received: (qmail 25899 invoked by uid 99); 21 Sep 2012 21:44:51 -0000
Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Sep 2012 21:44:50 +0000
Received: from localhost (HELO mail-ie0-f170.google.com) (127.0.0.1)
  (smtp-auth username olamy, mechanism plain)
  by minotaur.apache.org (qpsmtpd/0.29) with ESMTP;
 Fri, 21 Sep 2012 21:44:50 +0000
Received: by iebc12 with SMTP id c12so6019342ieb.29
        for <dev@creadur.apache.org>; Fri, 21 Sep 2012 14:44:49 -0700 (PDT)
Received: by 10.50.188.225 with SMTP id gd1mr212173igc.15.1348263889870; Fri,
 21 Sep 2012 14:44:49 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.231.115.215 with HTTP; Fri, 21 Sep 2012 14:44:29 -0700 (PDT)
In-Reply-To: <505B7A64.4020001@apache.org>
References: 
 <CAPoyBqRW1UCHFCamxmVd0u11iPV39rY2AP_RJgs5F1qtyFy-ew@mail.gmail.com>
 <CAPoyBqSZpP6SqyDKDGM3=d6qg+CKCgjxt9O7VE3qKsCE_B3rWg@mail.gmail.com>
 <505604FE.7020206@blueyonder.co.uk> <50562DB3.3000508@blueyonder.co.uk>
 <505B7A64.4020001@apache.org>
From: Olivier Lamy <olamy@apache.org>
Date: Fri, 21 Sep 2012 23:44:29 +0200
Message-ID: 
 <CAPoyBqS9g7tTZ=MAoQPG7UQ_vz5hRgskawRHAmjCbZ8xh8WwdQ@mail.gmail.com>
Subject: Re: Unit test failure in trunk
To: dev@creadur.apache.org
Content-Type: text/plain; charset=ISO-8859-1

Sure I have seen the change  :-)
Thanks it works now.
I will try to propose some patches for the maven plugin (probably next week)


2012/9/20 Robert Burrell Donkin <rdonkin@apache.org>:
> On 09/16/12 20:51, Robert Burrell Donkin wrote:
>>
>> On 09/16/12 17:57, Robert Burrell Donkin wrote:
>>>
>>> On 08/30/12 22:11, Olivier Lamy wrote:
>>>>
>>>> any idea ?
>>
>>
>> <snip>
>>
>>>>> But I have a unit test failure in trunk:
>>>>> Failed tests:
>>>>>
>>>>> realBinaryContent(org.apache.rat.document.impl.guesser.BinaryGuesserTest)
>>>>>
>>>>>
>>>>>
>>>>> I wonder if it's due to my env ?
>>>
>>>
>>> Quite possibly. I wonder whether this could be a platform encoding
>>> issue. I'll take a look at the code...
>>
>>
>> The binary guesses specifically (and probably rightly) uses the platform
>> encoding. This makes it a PITA to test. I think the best approach is to
>> make this test conditional on a suitable platform encoding. The binary
>> guesser code is reasonably stable, so I'm happy to trade a little test
>> coverage to allow Mac users to run the tests.
>
>
> I've committed code to make that test conditional (on platform encoding).
> Please give this another go, and see whether it works for you now...
>
> Robert



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy