Return-Path: X-Original-To: apmail-creadur-commits-archive@www.apache.org Delivered-To: apmail-creadur-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65FA4101DD for ; Sun, 8 Dec 2013 21:24:13 +0000 (UTC) Received: (qmail 94353 invoked by uid 500); 8 Dec 2013 21:24:13 -0000 Delivered-To: apmail-creadur-commits-archive@creadur.apache.org Received: (qmail 94326 invoked by uid 500); 8 Dec 2013 21:24:13 -0000 Mailing-List: contact commits-help@creadur.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@creadur.apache.org Delivered-To: mailing list commits@creadur.apache.org Received: (qmail 94319 invoked by uid 99); 8 Dec 2013 21:24:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Dec 2013 21:24:13 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Dec 2013 21:24:10 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 8A8292388868; Sun, 8 Dec 2013 21:23:49 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1549284 - in /creadur/rat/branches/gsoc/apache-rat-core/src: main/java/org/apache/rat/report/xml/writer/XmlWriterUtils.java test/java/org/apache/rat/report/xml/writer/XmlWriterUtilsTest.java Date: Sun, 08 Dec 2013 21:23:49 -0000 To: commits@creadur.apache.org From: rdonkin@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20131208212349.8A8292388868@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: rdonkin Date: Sun Dec 8 21:23:49 2013 New Revision: 1549284 URL: http://svn.apache.org/r1549284 Log: Apply PMD change. Modified: creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/XmlWriterUtils.java creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/XmlWriterUtilsTest.java Modified: creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/XmlWriterUtils.java URL: http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/XmlWriterUtils.java?rev=1549284&r1=1549283&r2=1549284&view=diff ============================================================================== --- creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/XmlWriterUtils.java (original) +++ creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/XmlWriterUtils.java Sun Dec 8 21:23:49 2013 @@ -23,7 +23,14 @@ import java.io.IOException; /** * The Class XmlWriterUtils. */ -public class XmlWriterUtils { +public final class XmlWriterUtils { + + /** + * Instantiates a new xml writer utils. + */ + public XmlWriterUtils() { + super(); + } /** * Write attribute. @@ -37,7 +44,7 @@ public class XmlWriterUtils { * @throws IOException * Signals that an I/O exception has occurred. */ - public static final void writeAttribute(final IXmlWriter writer, + public void writeAttribute(final IXmlWriter writer, final String name, final boolean booleanValue) throws IOException { final String value = Boolean.toString(booleanValue); writer.attribute(name, value); Modified: creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/XmlWriterUtilsTest.java URL: http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/XmlWriterUtilsTest.java?rev=1549284&r1=1549283&r2=1549284&view=diff ============================================================================== --- creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/XmlWriterUtilsTest.java (original) +++ creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/XmlWriterUtilsTest.java Sun Dec 8 21:23:49 2013 @@ -18,13 +18,13 @@ */ package org.apache.rat.report.xml.writer; -import org.apache.rat.report.xml.writer.impl.base.XmlWriter; -import org.junit.Before; -import org.junit.Test; +import static org.junit.Assert.assertEquals; import java.io.StringWriter; -import static org.junit.Assert.assertEquals; +import org.apache.rat.report.xml.writer.impl.base.XmlWriter; +import org.junit.Before; +import org.junit.Test; public class XmlWriterUtilsTest { @@ -40,13 +40,13 @@ public class XmlWriterUtilsTest { @Test public void writeTrue() throws Exception { - XmlWriterUtils.writeAttribute(writer, "name", true); + new XmlWriterUtils().writeAttribute(writer, "name", true); assertEquals("Attribute written as True", "