Return-Path: X-Original-To: apmail-creadur-commits-archive@www.apache.org Delivered-To: apmail-creadur-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 218D010FA6 for ; Sun, 8 Dec 2013 19:46:01 +0000 (UTC) Received: (qmail 39455 invoked by uid 500); 8 Dec 2013 19:46:01 -0000 Delivered-To: apmail-creadur-commits-archive@creadur.apache.org Received: (qmail 39428 invoked by uid 500); 8 Dec 2013 19:46:01 -0000 Mailing-List: contact commits-help@creadur.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@creadur.apache.org Delivered-To: mailing list commits@creadur.apache.org Received: (qmail 39421 invoked by uid 99); 8 Dec 2013 19:46:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Dec 2013 19:46:01 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Dec 2013 19:46:00 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id EB9312388868; Sun, 8 Dec 2013 19:45:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: svn commit: r1549148 - /creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/analysis/HeaderCheckWorkerTest.java Date: Sun, 08 Dec 2013 19:45:39 -0000 To: commits@creadur.apache.org From: rdonkin@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20131208194539.EB9312388868@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: rdonkin Date: Sun Dec 8 19:45:39 2013 New Revision: 1549148 URL: http://svn.apache.org/r1549148 Log: Rename Test, Only one assert for each test. Modified: creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/analysis/HeaderCheckWorkerTest.java Modified: creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/analysis/HeaderCheckWorkerTest.java URL: http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/analysis/HeaderCheckWorkerTest.java?rev=1549148&r1=1549147&r2=1549148&view=diff ============================================================================== --- creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/analysis/HeaderCheckWorkerTest.java (original) +++ creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/analysis/HeaderCheckWorkerTest.java Sun Dec 8 19:45:39 2013 @@ -24,6 +24,7 @@ import static org.junit.Assert.assertNot import static org.junit.Assert.assertTrue; import java.io.ByteArrayInputStream; +import java.io.IOException; import java.io.InputStream; import java.io.InputStreamReader; import java.io.Reader; @@ -40,19 +41,31 @@ import org.junit.Test; */ public class HeaderCheckWorkerTest { + /** - * Checks if is finished. + * Not finished. * - * @throws Exception - * the exception */ @Test - public void isFinished() throws Exception { + public void notFinished() { + final Document subject = new MockLocation("subject"); + HeaderCheckWorker worker = new HeaderCheckWorker(new StringReader(""), + new ApacheSoftwareLicense20(), subject); + assertFalse("Work status can´t be finished", worker.isFinished()); + } + + /** + * Checks if is finished. + * + * @throws IOException + * Signals that an I/O exception has occurred. + */ + @Test + public void isFinished() throws IOException { final Document subject = new MockLocation("subject"); HeaderCheckWorker worker = new HeaderCheckWorker(new StringReader(""), new ApacheSoftwareLicense20(), subject); - assertFalse(worker.isFinished()); worker.read(); - assertTrue(worker.isFinished()); + assertTrue("Work status must be finished", worker.isFinished()); } /** @@ -64,13 +77,14 @@ public class HeaderCheckWorkerTest { @Test public void testHeaderCheckWorkerConstructor() throws UnsupportedEncodingException { - InputStream in = new ByteArrayInputStream("Test".getBytes("UTF-8")); - Reader reader = new InputStreamReader(in, "UTF-8"); + InputStream inputStream = new ByteArrayInputStream( + "Test".getBytes("UTF-8")); + Reader reader = new InputStreamReader(inputStream, "UTF-8"); IHeaderMatcher matcher = null; int numberOfRetainedHeaderLine = 0; Document name = null; HeaderCheckWorker headerCheckWorker = new HeaderCheckWorker(reader, numberOfRetainedHeaderLine, matcher, name); - assertNotNull(headerCheckWorker); + assertNotNull("Not null", headerCheckWorker); } }