Return-Path: X-Original-To: apmail-creadur-commits-archive@www.apache.org Delivered-To: apmail-creadur-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 352DA1091E for ; Fri, 6 Dec 2013 09:40:23 +0000 (UTC) Received: (qmail 65533 invoked by uid 500); 6 Dec 2013 09:38:46 -0000 Delivered-To: apmail-creadur-commits-archive@creadur.apache.org Received: (qmail 65508 invoked by uid 500); 6 Dec 2013 09:38:43 -0000 Mailing-List: contact commits-help@creadur.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@creadur.apache.org Delivered-To: mailing list commits@creadur.apache.org Received: (qmail 65470 invoked by uid 99); 6 Dec 2013 09:38:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Dec 2013 09:38:40 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Dec 2013 09:38:39 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 9A7302388993; Fri, 6 Dec 2013 09:38:18 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1548467 - in /creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license: BaseLicense.java CopyrightHeader.java FullTextMatchingLicense.java Date: Fri, 06 Dec 2013 09:38:18 -0000 To: commits@creadur.apache.org From: rdonkin@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20131206093818.9A7302388993@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: rdonkin Date: Fri Dec 6 09:38:18 2013 New Revision: 1548467 URL: http://svn.apache.org/r1548467 Log: Apply PMD Rules. Modified: creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/BaseLicense.java creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/CopyrightHeader.java creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/FullTextMatchingLicense.java Modified: creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/BaseLicense.java URL: http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/BaseLicense.java?rev=1548467&r1=1548466&r2=1548467&view=diff ============================================================================== --- creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/BaseLicense.java (original) +++ creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/BaseLicense.java Fri Dec 6 09:38:18 2013 @@ -37,12 +37,6 @@ public class BaseLicense { /** * Instantiates a new base license. - */ - public BaseLicense() { - } - - /** - * Instantiates a new base license. * * @param licenseFamilyCategory * the license family category @@ -85,7 +79,7 @@ public class BaseLicense { * @param pDocumentCategory * the new license family category */ - public void setLicenseFamilyCategory(String pDocumentCategory) { + public void setLicenseFamilyCategory(final String pDocumentCategory) { licenseFamilyCategory = pDocumentCategory; } @@ -104,7 +98,7 @@ public class BaseLicense { * @param pLicenseFamilyCategory * the new license family name */ - public void setLicenseFamilyName(String pLicenseFamilyCategory) { + public void setLicenseFamilyName(final String pLicenseFamilyCategory) { licenseFamilyName = pLicenseFamilyCategory; } @@ -123,7 +117,7 @@ public class BaseLicense { * @param pNotes * the new notes */ - public void setNotes(String pNotes) { + public void setNotes(final String pNotes) { notes = pNotes; } @@ -133,7 +127,7 @@ public class BaseLicense { * @param subject * the subject */ - public final void reportOnLicense(Document subject) { + public final void reportOnLicense(final Document subject) { final MetaData metaData = subject.getMetaData(); metaData.set(new MetaData.Datum(MetaData.RAT_URL_HEADER_SAMPLE, notes)); final String licFamilyCategory = getLicenseFamilyCategory(); @@ -152,13 +146,13 @@ public class BaseLicense { * the text * @return the string */ - protected static final String prune(String text) { + protected static final String prune(final String text) { final int length = text.length(); final StringBuilder buffer = new StringBuilder(length); for (int i = 0; i < length; i++) { - char at = text.charAt(i); - if (Character.isLetterOrDigit(at)) { - buffer.append(at); + char charIndex = text.charAt(i); + if (Character.isLetterOrDigit(charIndex)) { + buffer.append(charIndex); } } return buffer.toString(); Modified: creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/CopyrightHeader.java URL: http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/CopyrightHeader.java?rev=1548467&r1=1548466&r2=1548467&view=diff ============================================================================== --- creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/CopyrightHeader.java (original) +++ creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/CopyrightHeader.java Fri Dec 6 09:38:18 2013 @@ -51,9 +51,6 @@ public class CopyrightHeader extends Bas private String copyrightOwner; private boolean copyrightMatch = false; - public CopyrightHeader(){ - } - protected CopyrightHeader(Datum licenseFamilyCategory, Datum licenseFamilyName, String notes) { super(licenseFamilyCategory, licenseFamilyName, notes); } Modified: creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/FullTextMatchingLicense.java URL: http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/FullTextMatchingLicense.java?rev=1548467&r1=1548466&r2=1548467&view=diff ============================================================================== --- creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/FullTextMatchingLicense.java (original) +++ creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/analysis/license/FullTextMatchingLicense.java Fri Dec 6 09:38:18 2013 @@ -48,9 +48,6 @@ public class FullTextMatchingLicense ext private final StringBuilder buffer = new StringBuilder(); - public FullTextMatchingLicense() { - } - protected FullTextMatchingLicense(Datum licenseFamilyCategory, Datum licenseFamilyName, String notes,