creadur-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdon...@apache.org
Subject svn commit: r1549325 - in /creadur/rat/branches/gsoc/apache-rat-core/src: main/java/org/apache/rat/Report.java main/java/org/apache/rat/report/xml/XmlReportFactory.java test/java/org/apache/rat/report/xml/XmlReportFactoryTest.java
Date Sun, 08 Dec 2013 21:44:38 GMT
Author: rdonkin
Date: Sun Dec  8 21:44:38 2013
New Revision: 1549325

URL: http://svn.apache.org/r1549325
Log:
Apply PMD change.

Modified:
    creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/Report.java
    creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/report/xml/XmlReportFactory.java
    creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/report/xml/XmlReportFactoryTest.java

Modified: creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/Report.java
URL: http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/Report.java?rev=1549325&r1=1549324&r2=1549325&view=diff
==============================================================================
--- creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/Report.java (original)
+++ creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/Report.java Sun
Dec  8 21:44:38 2013
@@ -393,7 +393,7 @@ public class Report {
             ReportConfiguration pConfiguration) throws IOException, RatException {
         IXmlWriter writer = new XmlWriter(out);
         final ClaimStatistic statistic = new ClaimStatistic();
-        RatReport report = XmlReportFactory.createStandardReport(writer, statistic, pConfiguration);
+        RatReport report = new XmlReportFactory().createStandardReport(writer, statistic,
pConfiguration);
         report.startReport();
         container.run(report);
         report.endReport();

Modified: creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/report/xml/XmlReportFactory.java
URL: http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/report/xml/XmlReportFactory.java?rev=1549325&r1=1549324&r2=1549325&view=diff
==============================================================================
--- creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/report/xml/XmlReportFactory.java
(original)
+++ creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/report/xml/XmlReportFactory.java
Sun Dec  8 21:44:38 2013
@@ -39,6 +39,13 @@ import org.apache.rat.report.xml.writer.
 public class XmlReportFactory {
 
 	/**
+	 * Instantiates a new xml report factory.
+	 */
+	public XmlReportFactory() {
+		super();
+	}
+
+	/**
 	 * Creates a new XmlReport object.
 	 * 
 	 * @param writer
@@ -49,7 +56,7 @@ public class XmlReportFactory {
 	 *            the configuration
 	 * @return the rat report
 	 */
-	public static final RatReport createStandardReport(final IXmlWriter writer,
+	public final RatReport createStandardReport(final IXmlWriter writer,
 			final ClaimStatistic pStatistic,
 			final ReportConfiguration pConfiguration) {
 		final List<RatReport> reporters = new ArrayList<RatReport>();

Modified: creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/report/xml/XmlReportFactoryTest.java
URL: http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/report/xml/XmlReportFactoryTest.java?rev=1549325&r1=1549324&r2=1549325&view=diff
==============================================================================
--- creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/report/xml/XmlReportFactoryTest.java
(original)
+++ creadur/rat/branches/gsoc/apache-rat-core/src/test/java/org/apache/rat/report/xml/XmlReportFactoryTest.java
Sun Dec  8 21:44:38 2013
@@ -18,6 +18,13 @@
  */ 
 package org.apache.rat.report.xml;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import java.io.File;
+import java.io.StringWriter;
+import java.util.regex.Pattern;
+
 import org.apache.rat.ReportConfiguration;
 import org.apache.rat.analysis.MockLicenseMatcher;
 import org.apache.rat.api.MetaData;
@@ -30,13 +37,6 @@ import org.apache.rat.walker.DirectoryWa
 import org.junit.Before;
 import org.junit.Test;
 
-import java.io.File;
-import java.io.StringWriter;
-import java.util.regex.Pattern;
-
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
-
 public class XmlReportFactoryTest {
 
     private static final Pattern IGNORE_EMPTY = Pattern.compile(".svn|Empty.txt");
@@ -63,7 +63,8 @@ public class XmlReportFactoryTest {
         final ClaimStatistic statistic = new ClaimStatistic();
         final ReportConfiguration configuration = new ReportConfiguration();
         configuration.setHeaderMatcher(mockLicenseMatcher);
-        RatReport report = XmlReportFactory.createStandardReport(writer, statistic, configuration);
+		RatReport report = new XmlReportFactory().createStandardReport(writer,
+				statistic, configuration);
         report.startReport();
         report(directory, report);
         report.endReport();



Mime
View raw message